| Message ID | 5c282efc-0734-9153-905c-e54ffbc82f60@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | baa71622cf67519c79a9968e202a35de45cc330b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: remove comment about apparently non-existing chip versions | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 2 Sep 2022 22:21:57 +0200 you wrote: > It's not clear where these entries came from, and as I wrote in the > comment: Not even Realtek's r8101 driver knows these chip id's. > So remove the comment. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/realtek/r8169_main.c | 6 ------ > 1 file changed, 6 deletions(-) Here is the summary with links: - [net-next] r8169: remove comment about apparently non-existing chip versions https://git.kernel.org/netdev/net-next/c/baa71622cf67 You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 779ca268d..a8b0070bb 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2050,12 +2050,6 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii) { 0x7c8, 0x348, RTL_GIGA_MAC_VER_09 }, { 0x7c8, 0x248, RTL_GIGA_MAC_VER_09 }, { 0x7c8, 0x340, RTL_GIGA_MAC_VER_16 }, - /* FIXME: where did these entries come from ? -- FR - * Not even r8101 vendor driver knows these id's, - * so let's disable detection for now. -- HK - * { 0xfc8, 0x388, RTL_GIGA_MAC_VER_13 }, - * { 0xfc8, 0x308, RTL_GIGA_MAC_VER_13 }, - */ /* 8110 family. */ { 0xfc8, 0x980, RTL_GIGA_MAC_VER_06 },
It's not clear where these entries came from, and as I wrote in the comment: Not even Realtek's r8101 driver knows these chip id's. So remove the comment. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 6 ------ 1 file changed, 6 deletions(-)