diff mbox series

libbpf: Clean up legacy bpf maps declaration in bpf_helpers

Message ID 6d349d1047f44001b926f80ad5416245@huawei.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series libbpf: Clean up legacy bpf maps declaration in bpf_helpers | expand

Checks

Context Check Description
bpf/vmtest-bpf-PR fail merge-conflict
netdev/tree_selection success Not a local patch

Commit Message

Xin Liu Sept. 5, 2022, 8:38 a.m. UTC
Legacy bpf maps declaration were no longer supported in Libbpf 1.0,
so it was time to remove the definition of bpf_map_def in
bpf_helpers.h.

LINK:[1] https://github.com/libbpf/libbpf/wiki/Libbpf:-the-road-to-v1.0

Signed-off-by: Liu Xin<liuxin350@huawei.com>
---
tools/lib/bpf/bpf_helpers.h | 12 ------------
1 file changed, 12 deletions(-)

--
2.33.0

Comments

Song Liu Sept. 6, 2022, 8:31 p.m. UTC | #1
On Mon, Sep 5, 2022 at 1:38 AM Liuxin(EulerOS) <liuxin350@huawei.com> wrote:
>
> Legacy bpf maps declaration were no longer supported in Libbpf 1.0,
> so it was time to remove the definition of bpf_map_def in
> bpf_helpers.h.
>
> LINK:[1] https://github.com/libbpf/libbpf/wiki/Libbpf:-the-road-to-v1.0
>
> Signed-off-by: Liu Xin<liuxin350@huawei.com>

This looks a little weird.

From: "Liuxin(EulerOS)" <liuxin350@huawei.com>

Please fix your name in git config:

Otherwise,

Acked-by: Song Liu <song@kernel.org>

> ---
> tools/lib/bpf/bpf_helpers.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
> index 867b73483..9cad13e7f 100644
> --- a/tools/lib/bpf/bpf_helpers.h
> +++ b/tools/lib/bpf/bpf_helpers.h
> @@ -167,18 +167,6 @@ bpf_tail_call_static(void *ctx, const void *map, const __u32 slot)
> }
> #endif
>
> -/*
> - * Helper structure used by eBPF C program
> - * to describe BPF map attributes to libbpf loader
> - */
> -struct bpf_map_def {
> -       unsigned int type;
> -       unsigned int key_size;
> -       unsigned int value_size;
> -       unsigned int max_entries;
> -       unsigned int map_flags;
> -} __attribute__((deprecated("use BTF-defined maps in .maps section")));
> -
> enum libbpf_pin_type {
>         LIBBPF_PIN_NONE,
>         /* PIN_BY_NAME: pin maps by name (in /sys/fs/bpf by default) */
> --
> 2.33.0
diff mbox series

Patch

diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
index 867b73483..9cad13e7f 100644
--- a/tools/lib/bpf/bpf_helpers.h
+++ b/tools/lib/bpf/bpf_helpers.h
@@ -167,18 +167,6 @@  bpf_tail_call_static(void *ctx, const void *map, const __u32 slot)
}
#endif

-/*
- * Helper structure used by eBPF C program
- * to describe BPF map attributes to libbpf loader
- */
-struct bpf_map_def {
-       unsigned int type;
-       unsigned int key_size;
-       unsigned int value_size;
-       unsigned int max_entries;
-       unsigned int map_flags;
-} __attribute__((deprecated("use BTF-defined maps in .maps section")));
-
enum libbpf_pin_type {
        LIBBPF_PIN_NONE,
        /* PIN_BY_NAME: pin maps by name (in /sys/fs/bpf by default) */