| Message ID | 709caac8873ff2a8b72b92091429be7c1a939959.1664900558.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 304ee24bdb43d095621669e926feab728454bc63 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: pse-pd: PSE_REGULATOR should depend on REGULATOR | expand |
On Tue, Oct 04, 2022 at 06:23:53PM +0200, Geert Uytterhoeven wrote: > The Regulator based PSE controller driver relies on regulator support to > be enabled. If regulator support is disabled, it will still compile > fine, but won't operate correctly. > > Hence add a dependency on REGULATOR, to prevent asking the user about > this driver when configuring a kernel without regulator support. > > Fixes: 66741b4e94ca7bb1 ("net: pse-pd: add regulator based PSE driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! > --- > drivers/net/pse-pd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig > index 73d163704068ac27..687dec49c1e13fa0 100644 > --- a/drivers/net/pse-pd/Kconfig > +++ b/drivers/net/pse-pd/Kconfig > @@ -14,6 +14,7 @@ if PSE_CONTROLLER > > config PSE_REGULATOR > tristate "Regulator based PSE controller" > + depends on REGULATOR || COMPILE_TEST > help > This module provides support for simple regulator based Ethernet Power > Sourcing Equipment without automatic classification support. For > -- > 2.25.1 > >
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 4 Oct 2022 18:23:53 +0200 you wrote: > The Regulator based PSE controller driver relies on regulator support to > be enabled. If regulator support is disabled, it will still compile > fine, but won't operate correctly. > > Hence add a dependency on REGULATOR, to prevent asking the user about > this driver when configuring a kernel without regulator support. > > [...] Here is the summary with links: - net: pse-pd: PSE_REGULATOR should depend on REGULATOR https://git.kernel.org/netdev/net/c/304ee24bdb43 You are awesome, thank you!
diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig index 73d163704068ac27..687dec49c1e13fa0 100644 --- a/drivers/net/pse-pd/Kconfig +++ b/drivers/net/pse-pd/Kconfig @@ -14,6 +14,7 @@ if PSE_CONTROLLER config PSE_REGULATOR tristate "Regulator based PSE controller" + depends on REGULATOR || COMPILE_TEST help This module provides support for simple regulator based Ethernet Power Sourcing Equipment without automatic classification support. For
The Regulator based PSE controller driver relies on regulator support to be enabled. If regulator support is disabled, it will still compile fine, but won't operate correctly. Hence add a dependency on REGULATOR, to prevent asking the user about this driver when configuring a kernel without regulator support. Fixes: 66741b4e94ca7bb1 ("net: pse-pd: add regulator based PSE driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/pse-pd/Kconfig | 1 + 1 file changed, 1 insertion(+)