| Message ID | 70c0744f-89ae-1869-7e3e-4fa292158f4b@virtuozzo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2d85a1b31dde84038ea07ad825c3d8d3e71f4344 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [NET] ipv6: ip6_finish_output2: set sk into newly allocated nskb | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | fail | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 19 Jul 2021 10:55:14 +0300 you wrote: > skb_set_owner_w() should set sk not to old skb but to new nskb. > > Fixes: 5796015fa968("ipv6: allocate enough headroom in ip6_finish_output2()") > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> > --- > net/ipv6/ip6_output.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [NET] ipv6: ip6_finish_output2: set sk into newly allocated nskb https://git.kernel.org/netdev/net/c/2d85a1b31dde You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 01bea76..e1b9f7a 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -74,7 +74,7 @@ static int ip6_finish_output2(struct net *net, struct sock *sk, struct sk_buff * if (likely(nskb)) { if (skb->sk) - skb_set_owner_w(skb, skb->sk); + skb_set_owner_w(nskb, skb->sk); consume_skb(skb); } else { kfree_skb(skb);
skb_set_owner_w() should set sk not to old skb but to new nskb. Fixes: 5796015fa968("ipv6: allocate enough headroom in ip6_finish_output2()") Signed-off-by: Vasily Averin <vvs@virtuozzo.com> --- net/ipv6/ip6_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)