From patchwork Thu Mar 31 08:20:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 12796836 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C754C433F5 for ; Thu, 31 Mar 2022 08:20:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232637AbiCaIW0 (ORCPT ); Thu, 31 Mar 2022 04:22:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232632AbiCaIWZ (ORCPT ); Thu, 31 Mar 2022 04:22:25 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED2F1B84FD; Thu, 31 Mar 2022 01:20:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id ECBBACE20FC; Thu, 31 Mar 2022 08:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F29CC340EE; Thu, 31 Mar 2022 08:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648714833; bh=iXTgKFinWeARny9umBHpFewtGh3ktJILaqMuf1C2Ki4=; h=From:To:Cc:Subject:Date:From; b=XlEjsUNMuFyGV1AFKM5uUXqTaQXIUNDx9OczEpSBAIwsFuh1k6rhL56wSNaAu2bMa XoIE9l96UgLY1rmvK4neZhttSkSh4gr26W3YlTn5KAWhoKCcibnRhEg9tWQNt+QbSG dV/VN4EZKtmcW5mAmIT0x4Pc0RV2uOVKrKX+TZiktpWWt74chiCass+fl6swsajFhP Az+NXH5p4qK34OR11g/xQZBxbadK7l+g79ZoM42BdAVyOpuxUPCNdLcHUnK0P+lUjQ rK9O8c1TogyMqZc7Y1wgfT7wpLeZoz407BRG6HK9OClSxlHngAul0DrTd2FWs6WQNe ctEOHb06wMD1w== From: Leon Romanovsky To: "David S . Miller" , Jakub Kicinski Cc: Leon Romanovsky , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , Jesse Brandeburg , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Paolo Abeni , Raed Salem , Shannon Nelson , Tony Nguyen , Shannon Nelson , Steffen Klassert Subject: [PATCH net v1] ixgbe: ensure IPsec VF<->PF compatibility Date: Thu, 31 Mar 2022 11:20:23 +0300 Message-Id: <737616899df2a482e4ec35aa4056c9ac608d2f50.1648714609.git.leonro@nvidia.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Leon Romanovsky The VF driver can forward any IPsec flags and such makes the function is not extendable and prone to backward/forward incompatibility. If new software runs on VF, it won't know that PF configured something completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag. Fixes: eda0333ac293 ("ixgbe: add VF IPsec management") Reviewed-by: Raed Salem Signed-off-by: Leon Romanovsky a Reviewed-by: Shannon Nelson Tested-by: Konrad Jankowski --- Chaagelog: v1: * Replaced bits arithmetic with more simple expression v0: https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.1648637865.git.leonro@nvidia.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c index e596e1a9fc75..69d11ff7677d 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c @@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf) /* Tx IPsec offload doesn't seem to work on this * device, so block these requests for now. */ - if (!(sam->flags & XFRM_OFFLOAD_INBOUND)) { + sam->flags = sam->flags & ~XFRM_OFFLOAD_IPV6; + if (sam->flags != XFRM_OFFLOAD_INBOUND) { err = -EOPNOTSUPP; goto err_out; }