| Message ID | 76a426018ec585c7dc40148fc832746e119dae60.1708370164.git.lucien.xin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d7f908103be90e8ac836ef0ce03b72997664b5a |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2] man: ip-link.8: add a note for gso_ipv4_max_size | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Mon, 19 Feb 2024 14:16:04 -0500 you wrote: > As Paolo noticed, a skb->len check against gso_max_size was added in: > > https://lore.kernel.org/netdev/20231219125331.4127498-1-edumazet@google.com/ > > gso_max_size needs to be set to a value greater than or equal to > gso_ipv4_max_size to make BIG TCP IPv4 work properly. > > [...] Here is the summary with links: - [iproute2] man: ip-link.8: add a note for gso_ipv4_max_size https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=1d7f908103be You are awesome, thank you!
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index c8c65657..444e7bca 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@ -441,6 +441,11 @@ TCP for IPv6 on this device when the size is greater than 65536. specifies the recommended maximum size of a IPv4 Generic Segment Offload packet the new device should accept. This is especially used to enable BIG TCP for IPv4 on this device by setting to a size greater than 65536. +Note that +.B gso_max_size +needs to be set to a size greater than or equal to +.B gso_ipv4_max_size +to really enable BIG TCP for IPv4. .TP .BI gso_max_segs " SEGMENTS "
As Paolo noticed, a skb->len check against gso_max_size was added in: https://lore.kernel.org/netdev/20231219125331.4127498-1-edumazet@google.com/ gso_max_size needs to be set to a value greater than or equal to gso_ipv4_max_size to make BIG TCP IPv4 work properly. To not break the current setup, this patch just adds a note into its man doc for this. Reported-by: Xiumei Mu <xmu@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> --- man/man8/ip-link.8.in | 5 +++++ 1 file changed, 5 insertions(+)