| Message ID | 827d40181f9f90fb37702f44328e1614df7c0503.1675768112.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 02fc0e73e852f78ec374004f924b9d84275d0006 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] libbpf: always use libbpf_err to return an error in bpf_xdp_query() | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Tue, 7 Feb 2023 12:11:03 +0100 you wrote: > In order to properly set errno, rely on libbpf_err utility routine in > bpf_xdp_query() to return an error to the caller. > > Fixes: 04d58f1b26a4 ("libbpf: add API to get XDP/XSK supported features") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > tools/lib/bpf/netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [bpf-next] libbpf: always use libbpf_err to return an error in bpf_xdp_query() https://git.kernel.org/bpf/bpf-next/c/02fc0e73e852 You are awesome, thank you!
diff --git a/tools/lib/bpf/netlink.c b/tools/lib/bpf/netlink.c index 32b13b7a11b0..cb082a04ffa8 100644 --- a/tools/lib/bpf/netlink.c +++ b/tools/lib/bpf/netlink.c @@ -480,7 +480,7 @@ int bpf_xdp_query(int ifindex, int xdp_flags, struct bpf_xdp_query_opts *opts) err = nlattr_add(&req, NETDEV_A_DEV_IFINDEX, &ifindex, sizeof(ifindex)); if (err < 0) - return err; + return libbpf_err(err); err = libbpf_netlink_send_recv(&req, NETLINK_GENERIC, parse_xdp_features, NULL, &md);
In order to properly set errno, rely on libbpf_err utility routine in bpf_xdp_query() to return an error to the caller. Fixes: 04d58f1b26a4 ("libbpf: add API to get XDP/XSK supported features") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- tools/lib/bpf/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)