| Message ID | 875cdcf4-843c-420a-ad5d-417447b68572@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 982300c115d229565d7af8e8b38aa1ee7bb1f5bd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: remove detection of chip version 11 (early RTL8168b) | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 27 May 2024 21:20:16 +0200 you wrote: > This early RTL8168b version was the first PCIe chip version, and it's > quite quirky. Last sign of life is from more than 15 yrs ago. > Let's remove detection of this chip version, we'll see whether anybody > complains. If not, support for this chip version can be removed a few > kernel versions later. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] r8169: remove detection of chip version 11 (early RTL8168b) https://git.kernel.org/netdev/net-next/c/982300c115d2 You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index e9f5185e4..9be254373 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2274,7 +2274,9 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii) /* 8168B family. */ { 0x7c8, 0x380, RTL_GIGA_MAC_VER_17 }, - { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + /* This one is very old and rare, let's see if anybody complains. + * { 0x7c8, 0x300, RTL_GIGA_MAC_VER_11 }, + */ /* 8101 family. */ { 0x7c8, 0x448, RTL_GIGA_MAC_VER_39 },
This early RTL8168b version was the first PCIe chip version, and it's quite quirky. Last sign of life is from more than 15 yrs ago. Let's remove detection of this chip version, we'll see whether anybody complains. If not, support for this chip version can be removed a few kernel versions later. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)