diff mbox series

[net-next,4/5] net: integrate QUIC build configuration into Kconfig and Makefile

Message ID 887eb7c776b63c613c6ac270442031be95de62f8.1725935420.git.lucien.xin@gmail.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series net: implement the QUIC protocol in linux kernel | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit fail Errors and warnings before: 16 this patch: 23
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 17 this patch: 17
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 22 this patch: 22
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Xin Long Sept. 10, 2024, 2:30 a.m. UTC 
This commit introduces build configurations for QUIC within the networking
subsystem. The Kconfig and Makefile files in the net directory are updated
to include options and rules necessary for building QUIC protocol support.

To enable building the QUIC module, include the following configurations
in your .config file:

  CONFIG_IP_QUIC=m
  CONFIG_IP_QUIC_TEST=m

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Moritz Buhl <mbuhl@openbsd.org>
Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
Signed-off-by: Pengtao He <hepengtao@xiaomi.com>
---
 net/Kconfig  | 1 +
 net/Makefile | 1 +
 2 files changed, 2 insertions(+)

Comments

Jakub Kicinski Sept. 12, 2024, midnight UTC | #1 
On Mon,  9 Sep 2024 22:30:19 -0400 Xin Long wrote:
> This commit introduces build configurations for QUIC within the networking
> subsystem. The Kconfig and Makefile files in the net directory are updated
> to include options and rules necessary for building QUIC protocol support.

Don't split out trivial config changes like this, what's the point.
It just make build testing harder.

Speaking of which, it doesn't build on 32bit:

ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined!
ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined!
ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined!

If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf
we won't have enough time to review for 6.12 even if Linus cuts -rc8.
Xin Long Sept. 12, 2024, 2:57 p.m. UTC | #2 
On Wed, Sep 11, 2024 at 8:01 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon,  9 Sep 2024 22:30:19 -0400 Xin Long wrote:
> > This commit introduces build configurations for QUIC within the networking
> > subsystem. The Kconfig and Makefile files in the net directory are updated
> > to include options and rules necessary for building QUIC protocol support.
>
> Don't split out trivial config changes like this, what's the point.
> It just make build testing harder.
I will move this to the Patch 3/5.

>
> Speaking of which, it doesn't build on 32bit:
>
> ERROR: modpost: "__udivmoddi4" [net/quic/quic.ko] undefined!
> ERROR: modpost: "__umoddi3" [net/quic/quic.ko] undefined!
> ERROR: modpost: "__udivdi3" [net/quic/quic.ko] undefined!
The tests were done on x86_64, aarch64, s390x and ppc64le.
Sorry for missing 32bit machines.

>
> If you repost before 6.12-rc1 please post as RFC, due to LPC / netconf
> we won't have enough time to review for 6.12 even if Linus cuts -rc8.
Copy that.

Thanks.
diff mbox series

Patch

diff --git a/net/Kconfig b/net/Kconfig
index d27d0deac0bf..3bbea4138c58 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -238,6 +238,7 @@  endif
 
 source "net/dccp/Kconfig"
 source "net/sctp/Kconfig"
+source "net/quic/Kconfig"
 source "net/rds/Kconfig"
 source "net/tipc/Kconfig"
 source "net/atm/Kconfig"
diff --git a/net/Makefile b/net/Makefile
index 65bb8c72a35e..0562e72482b9 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -44,6 +44,7 @@  obj-y				+= 8021q/
 endif
 obj-$(CONFIG_IP_DCCP)		+= dccp/
 obj-$(CONFIG_IP_SCTP)		+= sctp/
+obj-$(CONFIG_IP_QUIC)		+= quic/
 obj-$(CONFIG_RDS)		+= rds/
 obj-$(CONFIG_WIRELESS)		+= wireless/
 obj-$(CONFIG_MAC80211)		+= mac80211/