diff mbox series

net: microchip: Make FDMA config symbol invisible

Message ID 8e2bcd8899c417a962b7ee3f75b29f35b25d7933.1727171879.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 1910bd470a0acea01b88722be61f0dfa29089730
Delegated to: Netdev Maintainers
Headers show
Series net: microchip: Make FDMA config symbol invisible | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 17 this patch: 17
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 22 this patch: 22
netdev/checkpatch warning WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 30e48a75df9c ("net: microchip: add FDMA library")'
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-09-26--21-00 (tests: 768)

Commit Message

Geert Uytterhoeven Sept. 24, 2024, 9:59 a.m. UTC 
There is no need to ask the user about enabling Microchip FDMA
functionality, as all drivers that use it select the FDMA symbol.
Hence make the symbol invisible, unless when compile-testing.

Fixes: 30e48a75df9c6ead ("net: microchip: add FDMA library")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/microchip/fdma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Machon Sept. 24, 2024, 10:44 a.m. UTC | #1 
> There is no need to ask the user about enabling Microchip FDMA
> functionality, as all drivers that use it select the FDMA symbol.
> Hence make the symbol invisible, unless when compile-testing.
> 
> Fixes: 30e48a75df9c6ead ("net: microchip: add FDMA library")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
patchwork-bot+netdevbpf@kernel.org Oct. 1, 2024, 9:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 24 Sep 2024 11:59:09 +0200 you wrote:
> There is no need to ask the user about enabling Microchip FDMA
> functionality, as all drivers that use it select the FDMA symbol.
> Hence make the symbol invisible, unless when compile-testing.
> 
> Fixes: 30e48a75df9c6ead ("net: microchip: add FDMA library")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> [...]

Here is the summary with links:
  - net: microchip: Make FDMA config symbol invisible
    https://git.kernel.org/netdev/net/c/1910bd470a0a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/microchip/fdma/Kconfig b/drivers/net/ethernet/microchip/fdma/Kconfig
index 59159ad6701ad50b..ec228c0613517ec3 100644
--- a/drivers/net/ethernet/microchip/fdma/Kconfig
+++ b/drivers/net/ethernet/microchip/fdma/Kconfig
@@ -6,7 +6,7 @@ 
 if NET_VENDOR_MICROCHIP
 
 config FDMA
-	bool "FDMA API"
+	bool "FDMA API" if COMPILE_TEST
 	help
 	  Provides the basic FDMA functionality for multiple Microchip
 	  switchcores.