| Message ID | 8e7960cc-415d-48d7-99ce-f623022ec7b5@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3c97fe4f9fbc2bbc555b51268a9556e61cd3ca4e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 28 Sep 2024 13:04:01 +0300 you wrote: > This error handling has a typo. It should i++ instead of i--. In the > original code the error handling will loop until it crashes. > > Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> > Reviewed-by: Roger Quadros <rogerq@kernel.org> > > [...] Here is the summary with links: - [v2,net] net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code https://git.kernel.org/netdev/net/c/3c97fe4f9fbc You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index cbe99017cbfa..d253727b160f 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -763,7 +763,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) k3_udma_glue_disable_rx_chn(rx_chn->rx_chn); fail_rx: - for (i = 0; i < common->rx_ch_num_flows; i--) + for (i = 0; i < common->rx_ch_num_flows; i++) k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i], am65_cpsw_nuss_rx_cleanup, 0);
This error handling has a typo. It should i++ instead of i--. In the original code the error handling will loop until it crashes. Fixes: da70d184a8c3 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> Reviewed-by: Roger Quadros <rogerq@kernel.org> --- v2: The first version of this patch had white space corruption and didn't apply. drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)