| Message ID | 9400.1655407960@famine (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7a9214f3d88cfdb099f3896e102a306b316d8707 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers | expand |
On 6/16/22 15:32, Jay Vosburgh wrote: > The bonding ARP monitor fails to decrement send_peer_notif, the > number of peer notifications (gratuitous ARP or ND) to be sent. This > results in a continuous series of notifications. > > Correct this by decrementing the counter for each notification. > > Reported-by: Jonathan Toppins <jtoppins@redhat.com> > Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com> > Fixes: b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor") > Link: https://lore.kernel.org/netdev/b2fd4147-8f50-bebd-963a-1a3e8d1d9715@redhat.com/ Jay, this works great. Thanks. Tested-By: Jonathan Toppins <jtoppins@redhat.com> Reviewed-By: Jonathan Toppins <jtoppins@redhat.com>
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 16 Jun 2022 12:32:40 -0700 you wrote: > The bonding ARP monitor fails to decrement send_peer_notif, the > number of peer notifications (gratuitous ARP or ND) to be sent. This > results in a continuous series of notifications. > > Correct this by decrementing the counter for each notification. > > Reported-by: Jonathan Toppins <jtoppins@redhat.com> > Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com> > Fixes: b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor") > Link: https://lore.kernel.org/netdev/b2fd4147-8f50-bebd-963a-1a3e8d1d9715@redhat.com/ > > [...] Here is the summary with links: - [net] bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers https://git.kernel.org/netdev/net/c/7a9214f3d88c You are awesome, thank you!
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index f85372adf042..6ba4c83fe5fc 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -3684,9 +3684,11 @@ static void bond_activebackup_arp_mon(struct bonding *bond) if (!rtnl_trylock()) return; - if (should_notify_peers) + if (should_notify_peers) { + bond->send_peer_notif--; call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, bond->dev); + } if (should_notify_rtnl) { bond_slave_state_notify(bond); bond_slave_link_notify(bond);
The bonding ARP monitor fails to decrement send_peer_notif, the number of peer notifications (gratuitous ARP or ND) to be sent. This results in a continuous series of notifications. Correct this by decrementing the counter for each notification. Reported-by: Jonathan Toppins <jtoppins@redhat.com> Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com> Fixes: b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor") Link: https://lore.kernel.org/netdev/b2fd4147-8f50-bebd-963a-1a3e8d1d9715@redhat.com/ --- drivers/net/bonding/bond_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)