| Message ID | 97f68683b3b6c7ea8420c64817771cdedfded7ae.1628510543.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a2b6e3640c43a808dcb5226963e2cc0669294b1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] devlink: Fix port_type_set function pointer check | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 9 Aug 2021 15:03:19 +0300 you wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Fix a typo when checking existence of port_type_set function pointer. > > Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > > [...] Here is the summary with links: - [net-next] devlink: Fix port_type_set function pointer check https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Mon, Aug 09, 2021 at 12:40:05PM +0000, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net-next.git (refs/heads/master):a Dave, thanks a lot for your fast response. > > On Mon, 9 Aug 2021 15:03:19 +0300 you wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > > > Fix a typo when checking existence of port_type_set function pointer. > > > > Fixes: 82564f6c706a ("devlink: Simplify devlink port API calls") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > > > > [...] > > Here is the summary with links: > - [net-next] devlink: Fix port_type_set function pointer check > https://git.kernel.org/netdev/net-next/c/2a2b6e3640c4 > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > >
diff --git a/net/core/devlink.c b/net/core/devlink.c index d3b16dd9f64e..b02d54ab59ac 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -1274,7 +1274,7 @@ static int devlink_port_type_set(struct devlink_port *devlink_port, { int err; - if (devlink_port->devlink->ops->port_type_set) + if (!devlink_port->devlink->ops->port_type_set) return -EOPNOTSUPP; if (port_type == devlink_port->type)