| Message ID | 9b2054b2-0548-4f48-bf91-b646572093b4@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6994520a332887f1688464f250c9ec8002a89a8e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: disable interrupt source RxOverflow | expand |
> -----Original Message----- > From: Heiner Kallweit <hkallweit1@gmail.com> > Sent: Tuesday, May 28, 2024 12:47 AM > To: Paolo Abeni <pabeni@redhat.com>; Jakub Kicinski <kuba@kernel.org>; > David Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Realtek linux nic maintainers > <nic_swsd@realtek.com> > Cc: netdev@vger.kernel.org > Subject: [PATCH net-next] r8169: disable interrupt source > RxOverflow > > Vendor driver calls this bit RxDescUnavail. All we do in the interrupt handler in > this case is scheduling NAPI. If we should be out of RX descriptors, then NAPI > is scheduled anyway. Therefore remove this interrupt source. Tested on > RTL8168h. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/realtek/r8169_main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/realtek/r8169_main.c > b/drivers/net/ethernet/realtek/r8169_main.c > index e8f90a8fa..e9f5185e4 100644 > --- a/drivers/net/ethernet/realtek/r8169_main.c > +++ b/drivers/net/ethernet/realtek/r8169_main.c > @@ -5085,12 +5085,10 @@ static void rtl_set_irq_mask(struct > rtl8169_private *tp) > tp->irq_mask = RxOK | RxErr | TxOK | TxErr | LinkChg; > > if (tp->mac_version <= RTL_GIGA_MAC_VER_06) > - tp->irq_mask |= SYSErr | RxOverflow | RxFIFOOver; > + tp->irq_mask |= SYSErr | RxFIFOOver; > else if (tp->mac_version == RTL_GIGA_MAC_VER_11) > /* special workaround needed */ > tp->irq_mask |= RxFIFOOver; > - else > - tp->irq_mask |= RxOverflow; > } > > static int rtl_alloc_irq(struct rtl8169_private *tp) > -- > 2.45.1 > LGTM Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 27 May 2024 21:16:56 +0200 you wrote: > Vendor driver calls this bit RxDescUnavail. All we do in the interrupt > handler in this case is scheduling NAPI. If we should be out of > RX descriptors, then NAPI is scheduled anyway. Therefore remove this > interrupt source. Tested on RTL8168h. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] r8169: disable interrupt source RxOverflow https://git.kernel.org/netdev/net-next/c/6994520a3328 You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index e8f90a8fa..e9f5185e4 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5085,12 +5085,10 @@ static void rtl_set_irq_mask(struct rtl8169_private *tp) tp->irq_mask = RxOK | RxErr | TxOK | TxErr | LinkChg; if (tp->mac_version <= RTL_GIGA_MAC_VER_06) - tp->irq_mask |= SYSErr | RxOverflow | RxFIFOOver; + tp->irq_mask |= SYSErr | RxFIFOOver; else if (tp->mac_version == RTL_GIGA_MAC_VER_11) /* special workaround needed */ tp->irq_mask |= RxFIFOOver; - else - tp->irq_mask |= RxOverflow; } static int rtl_alloc_irq(struct rtl8169_private *tp)
Vendor driver calls this bit RxDescUnavail. All we do in the interrupt handler in this case is scheduling NAPI. If we should be out of RX descriptors, then NAPI is scheduled anyway. Therefore remove this interrupt source. Tested on RTL8168h. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)