From patchwork Fri Feb 7 09:13:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 13964662 X-Patchwork-Delegate: kuba@kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 747121D86CE; Fri, 7 Feb 2025 09:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738919640; cv=none; b=LdjjNBOjPaFjSt+0yBiGkyoqJThz8pllJQ9G8OOT2n3KdWiTsPE+ujVlUma7PNGybsUKQ5orgmW3p/ZIsfnBMpfcIi0PRwoDFdw1IUGa2oyLL31Nnvpp2aQojzXxioFFe4/lX6Z0+5b4D9uZZQW1LAOZ2GRUeekfVbtiz5MiXbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738919640; c=relaxed/simple; bh=GS5ky6+zhoGkum/n0efGVQjPu0p95hAeeVLQ/CMn4mI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=m33m+z+ItJkxV2ebPPxY0LqNdXgUqfNRD9x+xTrq0zmUef+MW9vX3xvDzc26fuPZ8IN+F75wiQ9Ws7ygNBGKMhINTgrZBSzVWCoRQ/ssusL/+TpdHEvqmI9GdElH1qM+7g0V3hwo+xgZ3z3xMOytqzkwnROZt79AJLp3ogR/NZg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=casper.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=jeeDBtCJ; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=casper.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jeeDBtCJ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y95Y+HtpyIVUja8P9QJUZepIX2HX2ocCC3swTjpEo1k=; b=jeeDBtCJ3T0PVE4fHz1k/9Sjcg T+9Kdc5F2O5BbILI9d2CSPTuSE1AiZKipyYiUgu7sG4Xh8wC3QDeymd+GmuaD+FsjrXwZnDylCUOE zRmkUbudA+lopUkwrLaerGtpH17H49Zgk1nVVKyIupckKPS2TiGiTuvxG0iUqIximgY7RlGSamrXU yFh9zomfgWoRxTnzGKyRvFmnAlcHTTRJz4yLAsQ8j5pxqgPdOEexjRQdnqMI7BtSuViuunAgcz43V ItDoMjC3DVRolTuBGEQ2Wi8decvrbjO4mZI4bIU+7vscF0ghzVPWk95uFnEy6VmIP9skHRaBFyady vSObkiww==; Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=freeip.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tgKQs-00000007XkW-4B4V; Fri, 07 Feb 2025 09:13:55 +0000 Message-ID: <9f5ee0186d6062eb31ed197d1b4a45c5eec110b2.camel@infradead.org> Subject: [PATCH net-next 5/4] ptp: vmclock: Add .owner to vmclock_miscdev_fops From: David Woodhouse To: Thomas =?iso-8859-1?q?Wei=DFschuh?= , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mateusz Polchlopek , "Mohamed Abuelfotoh, Hazem" Date: Fri, 07 Feb 2025 09:13:54 +0000 In-Reply-To: <20250206-vmclock-probe-v1-0-17a3ea07be34@linutronix.de> References: <20250206-vmclock-probe-v1-0-17a3ea07be34@linutronix.de> User-Agent: Evolution 3.52.3-0ubuntu1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Patchwork-Delegate: kuba@kernel.org From: David Woodhouse Without the .owner field, the module can be unloaded while /dev/vmclock0 is open, leading to an oops. Fixes: 205032724226 ("ptp: Add support for the AMZNC10C 'vmclock' device") Cc: stable@vger.kernel.org Signed-off-by: David Woodhouse --- drivers/ptp/ptp_vmclock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c index 26fcc1185ee7..b3a83b03d9c1 100644 --- a/drivers/ptp/ptp_vmclock.c +++ b/drivers/ptp/ptp_vmclock.c @@ -414,6 +414,7 @@ static ssize_t vmclock_miscdev_read(struct file *fp, char __user *buf, } static const struct file_operations vmclock_miscdev_fops = { + .owner = THIS_MODULE, .mmap = vmclock_miscdev_mmap, .read = vmclock_miscdev_read, };