| Message ID | E1mxqBh-00GWxo-51@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: axienet: modernise pcs implementation | expand |
On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > Convert axienet to use the phylink_pcs layer, resulting in it no longer > being a legacy driver. > > One oddity in this driver is that lp->switch_x_sgmii controls whether > we support switching between SGMII and 1000baseX. However, when clear, > this also blocks updating the 1000baseX advertisement, which it > probably should not be doing. Nevertheless, this behaviour is preserved > but a comment is added. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local'
On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > being a legacy driver. > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > we support switching between SGMII and 1000baseX. However, when clear, > > this also blocks updating the 1000baseX advertisement, which it > > probably should not be doing. Nevertheless, this behaviour is preserved > > but a comment is added. > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' Fixed that and the sha1 issue you raised in patch 2. Since both are "documentation" issues, I won't send out replacement patches until I've heard they've been tested on hardware though. Thanks!
+ Harini > -----Original Message----- > From: Russell King <linux@armlinux.org.uk> > Sent: Thursday, December 16, 2021 10:32 PM > To: Jakub Kicinski <kuba@kernel.org> > Cc: Michal Simek <michals@xilinx.com>; Radhey Shyam Pandey > <radheys@xilinx.com>; Sean Anderson <sean.anderson@seco.com>; David S. > Miller <davem@davemloft.net>; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > Convert axienet to use the phylink_pcs layer, resulting in it no > > > longer being a legacy driver. > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls > > > whether we support switching between SGMII and 1000baseX. However, > > > when clear, this also blocks updating the 1000baseX advertisement, > > > which it probably should not be doing. Nevertheless, this behaviour > > > is preserved but a comment is added. > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function > parameter or member 'pcs' not described in 'axienet_local' > > Fixed that and the sha1 issue you raised in patch 2. Since both are > "documentation" issues, I won't send out replacement patches until I've heard > they've been tested on hardware though. Thanks, series looks fine. I have added Harini to this thread and she will confirm it on hardware. > > Thanks! > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Hi Russell, On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > being a legacy driver. > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > we support switching between SGMII and 1000baseX. However, when clear, > > > this also blocks updating the 1000baseX advertisement, which it > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > but a comment is added. > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > Fixed that and the sha1 issue you raised in patch 2. Since both are > "documentation" issues, I won't send out replacement patches until > I've heard they've been tested on hardware though. Thanks for the patches. Series looks good and we're testing at our end; will get back to you early next week. Regards, Harini
On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@xilinx.com> wrote: > > Hi Russell, > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > <linux@armlinux.org.uk> wrote: > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > being a legacy driver. > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > this also blocks updating the 1000baseX advertisement, which it > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > but a comment is added. > > > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > "documentation" issues, I won't send out replacement patches until > > I've heard they've been tested on hardware though. > > Thanks for the patches. > Series looks good and we're testing at our end; will get back to you > early next week. Thanks Russell. I've tested AXI Ethernet and it works fine. Regards, Harini
On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote: > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@xilinx.com> wrote: > > > > Hi Russell, > > > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > > <linux@armlinux.org.uk> wrote: > > > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > > being a legacy driver. > > > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > > this also blocks updating the 1000baseX advertisement, which it > > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > > but a comment is added. > > > > > > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > > "documentation" issues, I won't send out replacement patches until > > > I've heard they've been tested on hardware though. > > > > Thanks for the patches. > > Series looks good and we're testing at our end; will get back to you > > early next week. > > Thanks Russell. I've tested AXI Ethernet and it works fine. Happy new year! Thanks - can I use that as a tested-by please, and would you be happy for me to send the patches for merging this week?
> -----Original Message----- > From: Russell King <linux@armlinux.org.uk> > Sent: Tuesday, January 4, 2022 2:31 PM > To: Harini Katakam <harinik@xilinx.com> > Cc: Jakub Kicinski <kuba@kernel.org>; Michal Simek <michals@xilinx.com>; > Radhey Shyam Pandey <radheys@xilinx.com>; Sean Anderson > <sean.anderson@seco.com>; David S. Miller <davem@davemloft.net>; > netdev <netdev@vger.kernel.org>; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs > > On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote: > > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@xilinx.com> wrote: > > > > > > Hi Russell, > > > > > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > > > <linux@armlinux.org.uk> wrote: > > > > > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > > > Convert axienet to use the phylink_pcs layer, resulting in it > > > > > > no longer being a legacy driver. > > > > > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls > > > > > > whether we support switching between SGMII and 1000baseX. > > > > > > However, when clear, this also blocks updating the 1000baseX > > > > > > advertisement, which it probably should not be doing. > > > > > > Nevertheless, this behaviour is preserved but a comment is added. > > > > > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > <rmk+kernel@armlinux.org.uk> > > > > > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function > parameter or member 'pcs' not described in 'axienet_local' > > > > > > > > Fixed that and the sha1 issue you raised in patch 2. Since both > > > > are "documentation" issues, I won't send out replacement patches > > > > until I've heard they've been tested on hardware though. > > > > > > Thanks for the patches. > > > Series looks good and we're testing at our end; will get back to you > > > early next week. > > > > Thanks Russell. I've tested AXI Ethernet and it works fine. > > Happy new year! > > Thanks - can I use that as a tested-by please, and would you be happy for me > to send the patches for merging this week? Sure, yes and yes. Tested-by: Harini Katakam <harini.katakam@xilinx.com> Happy new year to you too! Regards, Harini
On Tue, Jan 04, 2022 at 09:12:06AM +0000, Harini Katakam wrote: > > -----Original Message----- > > From: Russell King <linux@armlinux.org.uk> > > Sent: Tuesday, January 4, 2022 2:31 PM > > To: Harini Katakam <harinik@xilinx.com> > > Cc: Jakub Kicinski <kuba@kernel.org>; Michal Simek <michals@xilinx.com>; > > Radhey Shyam Pandey <radheys@xilinx.com>; Sean Anderson > > <sean.anderson@seco.com>; David S. Miller <davem@davemloft.net>; > > netdev <netdev@vger.kernel.org>; linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs > > > > On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote: > > > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@xilinx.com> wrote: > > > > > > > > Hi Russell, > > > > > > > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > > > > <linux@armlinux.org.uk> wrote: > > > > > > > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > > > > Convert axienet to use the phylink_pcs layer, resulting in it > > > > > > > no longer being a legacy driver. > > > > > > > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls > > > > > > > whether we support switching between SGMII and 1000baseX. > > > > > > > However, when clear, this also blocks updating the 1000baseX > > > > > > > advertisement, which it probably should not be doing. > > > > > > > Nevertheless, this behaviour is preserved but a comment is added. > > > > > > > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > > <rmk+kernel@armlinux.org.uk> > > > > > > > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function > > parameter or member 'pcs' not described in 'axienet_local' > > > > > > > > > > Fixed that and the sha1 issue you raised in patch 2. Since both > > > > > are "documentation" issues, I won't send out replacement patches > > > > > until I've heard they've been tested on hardware though. > > > > > > > > Thanks for the patches. > > > > Series looks good and we're testing at our end; will get back to you > > > > early next week. > > > > > > Thanks Russell. I've tested AXI Ethernet and it works fine. > > > > Happy new year! > > > > Thanks - can I use that as a tested-by please, and would you be happy for me > > to send the patches for merging this week? > > Sure, yes and yes. > Tested-by: Harini Katakam <harini.katakam@xilinx.com> > > Happy new year to you too! Thanks. While adding the attributation, I was reminded of this comment in the commit message: One oddity in this driver is that lp->switch_x_sgmii controls whether we support switching between SGMII and 1000baseX. However, when clear, this also blocks updating the 1000baseX advertisement, which it probably should not be doing. Nevertheless, this behaviour is preserved but a comment is added. went back to look at that, and realised that this was not the case at all, so patch 1 introduces a behaviour that wasn't originally there. I'll post an update, but essentially the change to patch 1 is: diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index a556f0215049..fbe0de4bc8dd 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1533,18 +1533,17 @@ static int axienet_pcs_config(struct phylink_pcs *pcs, unsigned int mode, struct axienet_local *lp = netdev_priv(ndev); int ret; - /* We don't support changing the advertisement in 1000base-X? --rmk */ - if (!lp->switch_x_sgmii) - return 0; - - ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr, - XLNX_MII_STD_SELECT_REG, - interface == PHY_INTERFACE_MODE_SGMII ? - XLNX_MII_STD_SELECT_SGMII : 0); - if (ret < 0) { - netdev_warn(ndev, "Failed to switch PHY interface: %d\n", - ret); - return ret; + if (lp->switch_x_sgmii) { + ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr, + XLNX_MII_STD_SELECT_REG, + interface == PHY_INTERFACE_MODE_SGMII ? + XLNX_MII_STD_SELECT_SGMII : 0); + if (ret < 0) { + netdev_warn(ndev, + "Failed to switch PHY interface: %d\n", + ret); + return ret; + } } ret = phylink_mii_c22_pcs_config(pcs_phy, mode, interface, advertising); and a corresponding change to patch 2 for the change in code formatting.
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h index 5b4d153b1492..81f09bd8f11c 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet.h +++ b/drivers/net/ethernet/xilinx/xilinx_axienet.h @@ -434,6 +434,7 @@ struct axienet_local { struct phylink_config phylink_config; struct mdio_device *pcs_phy; + struct phylink_pcs pcs; bool switch_x_sgmii; diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 23ac353b35fe..5edc8ec72317 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1509,78 +1509,80 @@ static const struct ethtool_ops axienet_ethtool_ops = { .nway_reset = axienet_ethtools_nway_reset, }; -static void axienet_mac_pcs_get_state(struct phylink_config *config, - struct phylink_link_state *state) +static struct axienet_local *pcs_to_axienet_local(struct phylink_pcs *pcs) { - struct net_device *ndev = to_net_dev(config->dev); - struct axienet_local *lp = netdev_priv(ndev); + return container_of(pcs, struct axienet_local, pcs); +} - switch (state->interface) { - case PHY_INTERFACE_MODE_SGMII: - case PHY_INTERFACE_MODE_1000BASEX: - phylink_mii_c22_pcs_get_state(lp->pcs_phy, state); - break; - default: - break; - } +static void axienet_pcs_get_state(struct phylink_pcs *pcs, + struct phylink_link_state *state) +{ + struct mdio_device *pcs_phy = pcs_to_axienet_local(pcs)->pcs_phy; + + phylink_mii_c22_pcs_get_state(pcs_phy, state); } -static void axienet_mac_an_restart(struct phylink_config *config) +static void axienet_pcs_an_restart(struct phylink_pcs *pcs) { - struct net_device *ndev = to_net_dev(config->dev); - struct axienet_local *lp = netdev_priv(ndev); + struct mdio_device *pcs_phy = pcs_to_axienet_local(pcs)->pcs_phy; - phylink_mii_c22_pcs_an_restart(lp->pcs_phy); + phylink_mii_c22_pcs_an_restart(pcs_phy); } -static int axienet_mac_prepare(struct phylink_config *config, unsigned int mode, - phy_interface_t iface) +static int axienet_pcs_config(struct phylink_pcs *pcs, unsigned int mode, + phy_interface_t interface, + const unsigned long *advertising, + bool permit_pause_to_mac) { - struct net_device *ndev = to_net_dev(config->dev); + struct mdio_device *pcs_phy = pcs_to_axienet_local(pcs)->pcs_phy; + struct net_device *ndev = pcs_to_axienet_local(pcs)->ndev; struct axienet_local *lp = netdev_priv(ndev); int ret; - switch (iface) { - case PHY_INTERFACE_MODE_SGMII: - case PHY_INTERFACE_MODE_1000BASEX: - if (!lp->switch_x_sgmii) - return 0; - - ret = mdiobus_write(lp->pcs_phy->bus, - lp->pcs_phy->addr, - XLNX_MII_STD_SELECT_REG, - iface == PHY_INTERFACE_MODE_SGMII ? - XLNX_MII_STD_SELECT_SGMII : 0); - if (ret < 0) - netdev_warn(ndev, "Failed to switch PHY interface: %d\n", - ret); - return ret; - default: + /* We don't support changing the advertisement in 1000base-X? --rmk */ + if (!lp->switch_x_sgmii) return 0; + + ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr, + XLNX_MII_STD_SELECT_REG, + interface == PHY_INTERFACE_MODE_SGMII ? + XLNX_MII_STD_SELECT_SGMII : 0); + if (ret < 0) { + netdev_warn(ndev, "Failed to switch PHY interface: %d\n", + ret); + return ret; } + + ret = phylink_mii_c22_pcs_config(pcs_phy, mode, interface, advertising); + if (ret < 0) + netdev_warn(ndev, "Failed to configure PCS: %d\n", ret); + + return ret; } -static void axienet_mac_config(struct phylink_config *config, unsigned int mode, - const struct phylink_link_state *state) +static const struct phylink_pcs_ops axienet_pcs_ops = { + .pcs_get_state = axienet_pcs_get_state, + .pcs_config = axienet_pcs_config, + .pcs_an_restart = axienet_pcs_an_restart, +}; + +static struct phylink_pcs *axienet_mac_select_pcs(struct phylink_config *config, + phy_interface_t interface) { struct net_device *ndev = to_net_dev(config->dev); struct axienet_local *lp = netdev_priv(ndev); - int ret; - switch (state->interface) { - case PHY_INTERFACE_MODE_SGMII: - case PHY_INTERFACE_MODE_1000BASEX: - ret = phylink_mii_c22_pcs_config(lp->pcs_phy, mode, - state->interface, - state->advertising); - if (ret < 0) - netdev_warn(ndev, "Failed to configure PCS: %d\n", - ret); - break; + if (interface == PHY_INTERFACE_MODE_1000BASEX || + interface == PHY_INTERFACE_MODE_SGMII) + return &lp->pcs; - default: - break; - } + return NULL; +} + +static void axienet_mac_config(struct phylink_config *config, unsigned int mode, + const struct phylink_link_state *state) +{ + /* nothing meaningful to do */ } static void axienet_mac_link_down(struct phylink_config *config, @@ -1635,9 +1637,7 @@ static void axienet_mac_link_up(struct phylink_config *config, static const struct phylink_mac_ops axienet_phylink_ops = { .validate = phylink_generic_validate, - .mac_pcs_get_state = axienet_mac_pcs_get_state, - .mac_an_restart = axienet_mac_an_restart, - .mac_prepare = axienet_mac_prepare, + .mac_select_pcs = axienet_mac_select_pcs, .mac_config = axienet_mac_config, .mac_link_down = axienet_mac_link_down, .mac_link_up = axienet_mac_link_up, @@ -2046,12 +2046,12 @@ static int axienet_probe(struct platform_device *pdev) ret = -EPROBE_DEFER; goto cleanup_mdio; } - lp->phylink_config.pcs_poll = true; + lp->pcs.ops = &axienet_pcs_ops; + lp->pcs.poll = true; } lp->phylink_config.dev = &ndev->dev; lp->phylink_config.type = PHYLINK_NETDEV; - lp->phylink_config.legacy_pre_march2020 = true; lp->phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10FD | MAC_100FD | MAC_1000FD;
Convert axienet to use the phylink_pcs layer, resulting in it no longer being a legacy driver. One oddity in this driver is that lp->switch_x_sgmii controls whether we support switching between SGMII and 1000baseX. However, when clear, this also blocks updating the 1000baseX advertisement, which it probably should not be doing. Nevertheless, this behaviour is preserved but a comment is added. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/xilinx/xilinx_axienet.h | 1 + .../net/ethernet/xilinx/xilinx_axienet_main.c | 112 +++++++++--------- 2 files changed, 57 insertions(+), 56 deletions(-)