From patchwork Thu Feb 3 17:31:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 12734430 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67911C433FE for ; Thu, 3 Feb 2022 17:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352880AbiBCRbn (ORCPT ); Thu, 3 Feb 2022 12:31:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352882AbiBCRbm (ORCPT ); Thu, 3 Feb 2022 12:31:42 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2646C06173B for ; Thu, 3 Feb 2022 09:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LT0yR0PeUj3iS0pQ3EBNu1UcT2mKQB/wbY+eKASwNJk=; b=A0yJIJIhVxdH0g3AoJ54Z5XZFx iUWMv6wVmNVAaFWkmEZXNI/fa2EQCclfVlMierJD3r92+7ke63gFql2msvqAa38R4GBDRMLBiUANh h7dkEcfCvsuu7405HhmL6F6EdTXLM5J4PZlA1ssV36XG61sHo7KQyOEuxLdA3oAWgxG6Fxez3DTr5 gHUnSnvmFYKk53UeOT20zX4oZiygc3ANZBh+PF2wL9w+yr0dhM8XQ25/+pA0mAxRczwBFHfKcY6KD VO9kWLMdsQMGo+HlhYGW3RcwA1soVi0SZtoiwVNvXkTu0cflXMzvwayTVFFuei5g7lr4TPbdGnpua 3ayyz5BQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:54888 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nFfxL-000303-1v; Thu, 03 Feb 2022 17:31:39 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nFfxK-006X72-Es; Thu, 03 Feb 2022 17:31:38 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: DENG Qingfang , Landen Chao , Sean Wang Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH RFC net-next 5/7] net: dsa: mt7530: RGMII can support 1000base-X MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Thu, 03 Feb 2022 17:31:38 +0000 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC When using an external PHY connected using RGMII to mt7531 port 5, the PHY can be used to used support 1000baseX connections. Therefore, it makes no sense to exclude this from the linkmodes permitted for mt7531 port 5, so allow 1000baseX. Signed-off-by: Russell King (Oracle) --- drivers/net/dsa/mt7530.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index cbdf4a58e507..a2fa629cccc0 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2523,9 +2523,6 @@ static void mt7531_sgmii_validate(struct mt7530_priv *priv, int port, */ switch (port) { case 5: - if (mt7531_is_rgmii_port(priv, port)) - break; - fallthrough; case 6: if (interface == PHY_INTERFACE_MODE_2500BASEX) { phylink_set(supported, 2500baseX_Full);