diff mbox series

[RFC,net-next,4/4] net: dsa: ocelot: mark as non-legacy

Message ID E1nNbgx-00Akj1-Sn@rmk-PC.armlinux.org.uk (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: ocelot: phylink updates | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: linux@armlinux.org.uk
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Russell King (Oracle) Feb. 25, 2022, 2:35 p.m. UTC 
The ocelot DSA driver does not make use of the speed, duplex, pause or
advertisement in its phylink_mac_config() implementation, so it can be
marked as a non-legacy driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/ocelot/felix.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Vladimir Oltean Feb. 25, 2022, 3:46 p.m. UTC | #1 
On Fri, Feb 25, 2022 at 02:35:31PM +0000, Russell King (Oracle) wrote:
> The ocelot DSA driver does not make use of the speed, duplex, pause or
> advertisement in its phylink_mac_config() implementation, so it can be
> marked as a non-legacy driver.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Russell King (Oracle) Feb. 25, 2022, 3:59 p.m. UTC | #2 
On Fri, Feb 25, 2022 at 03:46:50PM +0000, Vladimir Oltean wrote:
> On Fri, Feb 25, 2022 at 02:35:31PM +0000, Russell King (Oracle) wrote:
> > The ocelot DSA driver does not make use of the speed, duplex, pause or
> > advertisement in its phylink_mac_config() implementation, so it can be
> > marked as a non-legacy driver.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Hi Vladimir,

Shall I assume the tested-by applies to patch 2 and 3 as well?

Thanks.
Vladimir Oltean Feb. 25, 2022, 4 p.m. UTC | #3 
On Fri, Feb 25, 2022 at 03:59:42PM +0000, Russell King (Oracle) wrote:
> On Fri, Feb 25, 2022 at 03:46:50PM +0000, Vladimir Oltean wrote:
> > On Fri, Feb 25, 2022 at 02:35:31PM +0000, Russell King (Oracle) wrote:
> > > The ocelot DSA driver does not make use of the speed, duplex, pause or
> > > advertisement in its phylink_mac_config() implementation, so it can be
> > > marked as a non-legacy driver.
> > > 
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > > ---
> > 
> > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> Hi Vladimir,
> 
> Shall I assume the tested-by applies to patch 2 and 3 as well?
> 
> Thanks.

Yes.
diff mbox series

Patch

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 20ac74ee322d..f517bf902812 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -784,6 +784,12 @@  static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
 	struct ocelot *ocelot = ds->priv;
 	struct felix *felix = ocelot_to_felix(ocelot);
 
+	/* This driver does not make use of the speed, duplex, pause or the
+	 * advertisement in its mac_config, so it is safe to mark this driver
+	 * as non-legacy.
+	 */
+	config->legacy_pre_march2020 = false;
+
 	if (felix->info->phylink_get_caps)
 		felix->info->phylink_get_caps(ocelot, port, config);
 }