| Message ID | E1pdsE5-00Dl2l-8F@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ef70d0130f282638b28cfce24222f71ada00c9c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() | expand |
Hello, On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote: > pcs_get_state() implementations are not supposed to alter an_enabled. > Remove this assignment. > > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Any special reason to target the net-next tree? the fixes commit is quite old, and this looks like a -net candidate to me?!? Thanks! Paolo
On Tue, Mar 21, 2023 at 12:47:08PM +0100, Paolo Abeni wrote: > Hello, > > On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote: > > pcs_get_state() implementations are not supposed to alter an_enabled. > > Remove this assignment. > > > > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > Any special reason to target the net-next tree? the fixes commit is > quite old, and this looks like a -net candidate to me?!? It's a correctness issue rather than a bug fix, so I don't see why it should be applied to a -rc kernel.
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Sun, 19 Mar 2023 12:33:29 +0000 you wrote: > pcs_get_state() implementations are not supposed to alter an_enabled. > Remove this assignment. > > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > drivers/net/dsa/qca/qca8k-8xxx.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() https://git.kernel.org/netdev/net-next/c/9ef70d0130f2 You are awesome, thank you!
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c index 55df4479ea30..62810903f1b3 100644 --- a/drivers/net/dsa/qca/qca8k-8xxx.c +++ b/drivers/net/dsa/qca/qca8k-8xxx.c @@ -1483,7 +1483,6 @@ static void qca8k_pcs_get_state(struct phylink_pcs *pcs, state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP); state->an_complete = state->link; - state->an_enabled = !!(reg & QCA8K_PORT_STATUS_LINK_AUTO); state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL : DUPLEX_HALF;
pcs_get_state() implementations are not supposed to alter an_enabled. Remove this assignment. Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/dsa/qca/qca8k-8xxx.c | 1 - 1 file changed, 1 deletion(-)