From patchwork Fri May 12 17:27:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13239561 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19724200C1 for ; Fri, 12 May 2023 17:27:30 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2171E5D for ; Fri, 12 May 2023 10:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=r4QRE1IFWQbED7jjAaEnjMvKln+e+I3tfu99FI9BiPw=; b=D4pICVA2wI3UNatws53Lqq0lTD KnHVZQahwRv12KP0PF3tg/7h5IeMDOtwQPywzteKahBXaEfBDbnu1dQRkWYsmsl6hDY1I3rQoyvdI LezcZ4xNyteOgJHwIwEeibwBmY9dKE3ySHEQIqMExu3tBxPB2wfiuVyGa1wZQ5S551BB3D+nVQ9rW 4wWuCwVEyTU/c5UqA98QFABX86dodrjo+/CvbIcTVYsH8yQsMCcwbMZS2be3OqRBuEP83Hsfysclw WwdLZ/DG3paHgdQ9n8d94AUZ7z5ZIEPMZ7WCmZnMrRCzk+BGYAkwOlUTRy+LDyjQToRdisbfkIDae kw2sMmkQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:49362 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pxWY9-0000Dy-Ty; Fri, 12 May 2023 18:27:25 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pxWY9-002QsH-9V; Fri, 12 May 2023 18:27:25 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Jose Abreu Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Heiner Kallweit , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH RFC net-next 5/9] net: pcs: xpcs: use mii_c73_to_linkmode() helper Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Fri, 12 May 2023 18:27:25 +0100 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SORTED_RECIPS, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC Convert xpcs clause 73 reading to use the newly introduced mii_c73_to_linkmode() helper to translate the link partner advertisement to an ethtool bitmap. Signed-off-by: Russell King (Oracle) Reviewed-by: Andrew Lunn --- drivers/net/pcs/pcs-xpcs.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c index b8d69a78f484..16fcc7891f92 100644 --- a/drivers/net/pcs/pcs-xpcs.c +++ b/drivers/net/pcs/pcs-xpcs.c @@ -529,18 +529,7 @@ static int xpcs_read_lpa_c73(struct dw_xpcs *xpcs, lpa[i] = ret; } - if (lpa[2] & DW_C73_2500KX) - phylink_set(state->lp_advertising, 2500baseX_Full); - if (lpa[1] & DW_C73_1000KX) - phylink_set(state->lp_advertising, 1000baseKX_Full); - if (lpa[1] & DW_C73_10000KX4) - phylink_set(state->lp_advertising, 10000baseKX4_Full); - if (lpa[1] & DW_C73_10000KR) - phylink_set(state->lp_advertising, 10000baseKR_Full); - if (lpa[0] & DW_C73_PAUSE) - phylink_set(state->lp_advertising, Pause); - if (lpa[0] & DW_C73_ASYM_PAUSE) - phylink_set(state->lp_advertising, Asym_Pause); + mii_c73_mod_linkmode(state->lp_advertising, lpa); linkmode_and(state->lp_advertising, state->lp_advertising, state->advertising);