| Message ID | E1pzxQ0-0062IU-Ql@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8b6b7c1190c3da1137d320c3de5e8d7f69baba5b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: altera: tse: remove mac_an_restart() function | expand |
On Fri, May 19, 2023 at 11:33:04AM +0100, Russell King (Oracle) wrote: > The mac_an_restart() method will only be called if the driver sets > legacy_pre_march2020, which the altera tse driver does not do. > Therefore, providing a stub is unnecessary. > > Fixes: fef2998203e1 ("net: altera: tse: convert to phylink") > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 19 May 2023 11:33:04 +0100 you wrote: > The mac_an_restart() method will only be called if the driver sets > legacy_pre_march2020, which the altera tse driver does not do. > Therefore, providing a stub is unnecessary. > > Fixes: fef2998203e1 ("net: altera: tse: convert to phylink") > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > [...] Here is the summary with links: - [net-next] net: altera: tse: remove mac_an_restart() function https://git.kernel.org/netdev/net-next/c/8b6b7c1190c3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index 66e3af73ec41..190ff1bcd94e 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1036,10 +1036,6 @@ static struct net_device_ops altera_tse_netdev_ops = { .ndo_validate_addr = eth_validate_addr, }; -static void alt_tse_mac_an_restart(struct phylink_config *config) -{ -} - static void alt_tse_mac_config(struct phylink_config *config, unsigned int mode, const struct phylink_link_state *state) { @@ -1096,7 +1092,6 @@ static struct phylink_pcs *alt_tse_select_pcs(struct phylink_config *config, } static const struct phylink_mac_ops alt_tse_phylink_ops = { - .mac_an_restart = alt_tse_mac_an_restart, .mac_config = alt_tse_mac_config, .mac_link_down = alt_tse_mac_link_down, .mac_link_up = alt_tse_mac_link_up,
The mac_an_restart() method will only be called if the driver sets legacy_pre_march2020, which the altera tse driver does not do. Therefore, providing a stub is unnecessary. Fixes: fef2998203e1 ("net: altera: tse: convert to phylink") Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/altera/altera_tse_main.c | 5 ----- 1 file changed, 5 deletions(-)