| Message ID | E1qWxjI-0056nx-CU@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 44a696de720d6917f1d1844a05757624295b81c0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mdio: xgene: remove useless xgene_mdio_status | expand |
On Fri, Aug 18, 2023 at 12:33:24PM +0100, Russell King (Oracle) wrote: > xgene_mdio_status is declared static, and is only written once by the > driver. It appears to have been this way since the driver was first > added to the kernel tree. No other users can be found, so let's remove > it. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 18 Aug 2023 12:33:24 +0100 you wrote: > xgene_mdio_status is declared static, and is only written once by the > driver. It appears to have been this way since the driver was first > added to the kernel tree. No other users can be found, so let's remove > it. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > [...] Here is the summary with links: - [net-next] net: mdio: xgene: remove useless xgene_mdio_status https://git.kernel.org/netdev/net-next/c/44a696de720d You are awesome, thank you!
diff --git a/drivers/net/mdio/mdio-xgene.c b/drivers/net/mdio/mdio-xgene.c index 1af7a4d9f86c..1190a793555a 100644 --- a/drivers/net/mdio/mdio-xgene.c +++ b/drivers/net/mdio/mdio-xgene.c @@ -20,8 +20,6 @@ #include <linux/prefetch.h> #include <net/ip.h> -static bool xgene_mdio_status; - u32 xgene_mdio_rd_mac(struct xgene_mdio_pdata *pdata, u32 rd_addr) { void __iomem *addr, *rd, *cmd, *cmd_done; @@ -421,7 +419,6 @@ static int xgene_mdio_probe(struct platform_device *pdev) goto out_mdiobus; pdata->mdio_bus = mdio_bus; - xgene_mdio_status = true; return 0;
xgene_mdio_status is declared static, and is only written once by the driver. It appears to have been this way since the driver was first added to the kernel tree. No other users can be found, so let's remove it. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/mdio/mdio-xgene.c | 3 --- 1 file changed, 3 deletions(-)