From patchwork Tue Oct 8 14:41:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13826602 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6221DEFC7 for ; Tue, 8 Oct 2024 14:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728398504; cv=none; b=mFxZGPzsRKylyVYB3JIj/YClpYW5dSBzMpESDH/pe7bkc1zItGVZ4Ion3RtCCyI7XhxsSSYqVVo9NLr0w7YvJnhBkZS2LS8/tiVjNlDpKhMzPAHeK8/ebKTBixmIjnaWZ7yTCqItlWvX1G+aU4VGENheTBXL0SzgU7iq8tPv9F0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728398504; c=relaxed/simple; bh=DmLPmLRaziza5ewwjphLPzMhIQDGOKj2U5ryKGjIm7A=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=Xq/36gxE7ziwZk6lDmV9pNL7fmoqKVlSPea+zWQ2Nn6L++smBv1wWvMFgSmCI1XFETdigOkLpdBy5mh3tEZVY/ykbkKt8rdZq88Gx11kvDet3fYavbxXpoFpwCrl/5OUtv7oscvESH1YsxsprXR8dgYTQS8U8KniBt8xBys1eQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=ik59nFVS; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ik59nFVS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qlsgT3uh8K9k1PV5YZmeebJi1rGILfxVcCKMi1nm2lU=; b=ik59nFVSPrzkhdV9Ad1zs6HAgR Mgur03fznZuxKbMO4kwX10AWx3YpEiC8Cw/vV1/iV2UUjjc2U7AwiQ+PrKkDoZA5inXvz4VJPyVw4 z/Xg/9hSCtlNDEuYKMFviz52dmojHhDJ0lDWJie9+7vv0AuuC2wpkM0Wp/qSW7ZhY68MtIzfFXQoU 7Z0Y+0fZPb4/I8o5J4TfXIPjFMNlTFZGbzIOfIA6TKdsKxvT00oCCHHMgZ+QxFWcM2+x3pPyJAMBa scyEPh5JpXW2mYKN8AH+kfpqU7/eDnu15K0+0B7AArRnpaobpx2JZ+G5QxTWgiGjjADGjlrJ+SNya 8MiHNUNQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:40232 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1syBP6-0007cN-0a; Tue, 08 Oct 2024 15:41:35 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1syBP4-006UnV-Lk; Tue, 08 Oct 2024 15:41:34 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Vladimir Oltean Subject: [PATCH net-next 1/3] net: dsa: remove dsa_port_phylink_mac_select_pcs() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 08 Oct 2024 15:41:34 +0100 X-Patchwork-Delegate: kuba@kernel.org There is no longer any reason to implement the mac_select_pcs() callback in DSA. Returning ERR_PTR(-EOPNOTSUPP) is functionally equivalent to not providing the function. Signed-off-by: Russell King (Oracle) Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean # dsa_loop --- net/dsa/port.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/net/dsa/port.c b/net/dsa/port.c index f1e96706a701..ee0aaec4c8e0 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -1575,13 +1575,6 @@ void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp, cpu_dp->tag_ops = tag_ops; } -static struct phylink_pcs * -dsa_port_phylink_mac_select_pcs(struct phylink_config *config, - phy_interface_t interface) -{ - return ERR_PTR(-EOPNOTSUPP); -} - static void dsa_port_phylink_mac_config(struct phylink_config *config, unsigned int mode, const struct phylink_link_state *state) @@ -1604,7 +1597,6 @@ static void dsa_port_phylink_mac_link_up(struct phylink_config *config, } static const struct phylink_mac_ops dsa_port_phylink_mac_ops = { - .mac_select_pcs = dsa_port_phylink_mac_select_pcs, .mac_config = dsa_port_phylink_mac_config, .mac_link_down = dsa_port_phylink_mac_link_down, .mac_link_up = dsa_port_phylink_mac_link_up,