From patchwork Tue Nov 26 12:52:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13885876 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C9D194A66 for ; Tue, 26 Nov 2024 12:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732625574; cv=none; b=MGZcGCE27UT9owE4I4pcGkuQ1a5xR5YmhfrcSCwsgVcZPVXYAjKrwGhnJ4ZTx3fiI3Z9mrwvmaOZRTaKQgPjoXJosaUrqGD0NPr+QMIlfHTAC2/BV/j+dT3cwyf1CghNzaiBiWVum6yh797CCayC+jgspnrXg5vG+p+mZFxyaJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732625574; c=relaxed/simple; bh=VS1Jn0MKxK896HY0QyRsfm/vGGkWNaU0l71PD3kt0Vk=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=epmkLtfpt8l9Js38GOBuL4DId/JNBWME/610gbakAStQqXahT9cRdxjyTcy8jyonVM5WENbL5VqNoMOozV9lcdxlkU7QShu0pNSrnXETXM/LgcuzEqxlk1OGJnIUnNymL3BI2YiUkrR/I48qbPrGZcJ7LLNnBFKZ/yCUXvP3DzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=wX1MOib1; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="wX1MOib1" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hM2Me0R442AO8DdVkavZVZg2yJn2icgsmunMOQ2V1M8=; b=wX1MOib1+DBlN4WWej5Q/tAJhg REEjg+iOgD99ePnruIdxN3PHit10xMAL0SCEtX+1ivn5+3Uig2LSQ7jWOTTLZZ3tP7mvEOYaDx3MI w7RqcHlIQ0DpabuMDYzrm40JdYp6B1sMSVu+94MOTjjVIRaqDMWZd1oT6Ii3Y4GKske7T09MbDKMl Xr/pZblsQCeWm6dQay6GbIVcjKMa3Bgo/2ppNP4ePpIoQbvn31CTVkFIoG/pIQhwqtNEua1/fpAAW p6ClYCvzdA9pA4C9QW4ymb6YPqSh0JcfGk3XfCTw03tcaHi7LQxY3PNpnYgaKnryQcbdHxuv4O6O+ fGhRk24Q==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:34386 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tFv3a-0006sx-2x; Tue, 26 Nov 2024 12:52:43 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tFv3Z-005yhr-Os; Tue, 26 Nov 2024 12:52:41 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , Bryan Whitehead , "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Marcin Wojtas , Maxime Coquelin , netdev@vger.kernel.org, Oleksij Rempel , Paolo Abeni , UNGLinuxDriver@microchip.com Subject: [PATCH RFC net-next 06/23] net: phy: update phy_ethtool_get_eee() documentation Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 26 Nov 2024 12:52:41 +0000 X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC Update the phy_ethtool_get_eee() documentation to make it clear that all members of struct ethtool_keee are written by this function. keee.supported, keee.advertised, keee.lp_advertised and keee.eee_active are all written by genphy_c45_ethtool_get_eee(). keee.tx_lpi_timer, keee.tx_lpi_enabled and keee.eee_enabled are all written by eeecfg_to_eee(). Signed-off-by: Russell King (Oracle) --- drivers/net/phy/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 18109f843e39..8caef54a60e0 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1648,8 +1648,8 @@ EXPORT_SYMBOL(phy_get_eee_err); * @phydev: target phy_device struct * @data: ethtool_keee data * - * Description: reports the Supported/Advertisement/LP Advertisement - * capabilities, etc. + * Description: get the current EEE settings, filling in all members of + * @data. */ int phy_ethtool_get_eee(struct phy_device *phydev, struct ethtool_keee *data) {