| Message ID | E1tJ9JH-006LIz-SO@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f899c594e138eda72804b16babbdeff92707d7b0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phylib EEE cleanups | expand |
On Thu, Dec 05, 2024 at 10:42:15AM +0000, Russell King (Oracle) wrote: > Update the phy_ethtool_get_eee() documentation to make it clear that > all members of struct ethtool_keee are written by this function. > > keee.supported, keee.advertised, keee.lp_advertised and keee.eee_active > are all written by genphy_c45_ethtool_get_eee(). > > keee.tx_lpi_timer, keee.tx_lpi_enabled and keee.eee_enabled are all > written by eeecfg_to_eee(). > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 4cf344254237..e4b04cdaa995 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1701,8 +1701,8 @@ EXPORT_SYMBOL(phy_get_eee_err); * @phydev: target phy_device struct * @data: ethtool_keee data * - * Description: reports the Supported/Advertisement/LP Advertisement - * capabilities, etc. + * Description: get the current EEE settings, filling in all members of + * @data. */ int phy_ethtool_get_eee(struct phy_device *phydev, struct ethtool_keee *data) {
Update the phy_ethtool_get_eee() documentation to make it clear that all members of struct ethtool_keee are written by this function. keee.supported, keee.advertised, keee.lp_advertised and keee.eee_active are all written by genphy_c45_ethtool_get_eee(). keee.tx_lpi_timer, keee.tx_lpi_enabled and keee.eee_enabled are all written by eeecfg_to_eee(). Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/phy/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)