From patchwork Tue Jan 14 16:50:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13938974 X-Patchwork-Delegate: kuba@kernel.org Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB005232459 for ; Tue, 14 Jan 2025 16:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736873479; cv=none; b=S4aHWeZhepyAIX9QvGDzsiV/PdWfbESxHneXVVj7BB3oqBJNnKGSju6LfYCuo7X1kYauQXVbWU8m57LKYiTT91KVtCKt8sSg+0qebhVnpF21XjhsPi6ThBpW/s68fJGzsPYpF3iZH7Mh4+t+o7JFWaskONXwKNAr5NAj16TU2RI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736873479; c=relaxed/simple; bh=kxwJ6ZLf1F2kRoZrAiF1HSoEtcU5OHUSCywmpVYXh9M=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=Xk1pgFEm0D2e86oqazSejly1+iBwUH22Vn+HKXh6nNvzyYI4TC1fji+ZvPnTtxxXuK0usNdOGKOjS6+dCTnoPg09A7NguN/9t8AknqekCJKNbDwI6Cb5jgdI9yKEdNy7Kx9A5SliOhngPq0ZoLMueTaTxxWg8SdN5UL0ERvyQ5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=sQyC6mG6; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="sQyC6mG6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OaAYO4ab4fITs7juBW/FSfIp2nYrOC6gWB66JY5AddA=; b=sQyC6mG6GYkQpMQJCf3tH3J2qu 0bmlYAeqFJV56qZFSx5sFae82oaTOpFYZBbJ+RKILWO9DsR3eUvWNEkSCDkMpNeJyBXVx06E22SHV mCROmSLv/eRrYGL5JqYZqRQgMETl8nAKDIt+C4EDyKH6moTECilzVAwT8lH+iFK7u/+7lKfmz5u84 YRj6vI74B4pL7WEf1/QjH2xDSk4P7yAuJGfeIwn0aM1RCLzlvU3Qp8NT5SldDuNLH860z212FpuJE /4lCcJX/4hw9G8dmpWKNadAQZ4frmaAL1hVkXAe5Q8nd1clH/lqxMWq6GDPw3OmZ5jGriNbMbzCZS 5rjH5I+g==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:60486 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tXk8G-0008O4-0P; Tue, 14 Jan 2025 16:51:12 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1tXk7w-000r4r-Pq; Tue, 14 Jan 2025 16:50:52 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Andrew Lunn , bcm-kernel-feedback-list@broadcom.com, "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Justin Chen , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next 2/3] net: bcm: asp2: remove tx_lpi_enabled Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Message-Id: Sender: Russell King Date: Tue, 14 Jan 2025 16:50:52 +0000 X-Patchwork-Delegate: kuba@kernel.org Phylib maintains a copy of tx_lpi_enabled, which will be used to populate the member when phy_ethtool_get_eee(). Therefore, writing to this member before phy_ethtool_get_eee() will have no effect. Remove it. Also remove setting our copy of info->eee.tx_lpi_enabled which becomes write-only. Signed-off-by: Russell King (Oracle) Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli --- drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c b/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c index 139058a0dbbb..5e04cd1839c0 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c @@ -364,14 +364,9 @@ void bcmasp_eee_enable_set(struct bcmasp_intf *intf, bool enable) static int bcmasp_get_eee(struct net_device *dev, struct ethtool_keee *e) { - struct bcmasp_intf *intf = netdev_priv(dev); - struct ethtool_keee *p = &intf->eee; - if (!dev->phydev) return -ENODEV; - e->tx_lpi_enabled = p->tx_lpi_enabled; - return phy_ethtool_get_eee(dev->phydev, e); } @@ -394,7 +389,6 @@ static int bcmasp_set_eee(struct net_device *dev, struct ethtool_keee *e) return ret; } - intf->eee.tx_lpi_enabled = e->tx_lpi_enabled; bcmasp_eee_enable_set(intf, true); }