diff mbox series

[net-next,v9,1/4] wwan: core: Add WWAN fastboot port type

Message ID MEYP282MB26972B38E198B163EE7094DEBB472@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM (mailing list archive)
State Accepted
Commit e3caf184107a4e2e196528b98b218ddc41e4cb8c
Delegated to: Netdev Maintainers
Headers show
Series net: wwan: t7xx: Add fastboot interface | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1049 this patch: 1049
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 4 maintainers not CCed: angelogioacchino.delregno@collabora.com linux-mediatek@lists.infradead.org linux-arm-kernel@lists.infradead.org matthias.bgg@gmail.com
netdev/build_clang success Errors and warnings before: 1065 this patch: 1065
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1065 this patch: 1065
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 24 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-02-05--12-00 (tests: 721)

Commit Message

Jinjian Song Feb. 5, 2024, 10:22 a.m. UTC 
From: Jinjian Song <jinjian.song@fibocom.com>

Add a new WWAN port that connects to the device fastboot protocol
interface.

Signed-off-by: Jinjian Song <jinjian.song@fibocom.com>
---
v2-v9:
 * no change
---
 drivers/net/wwan/wwan_core.c | 4 ++++
 include/linux/wwan.h         | 2 ++
 2 files changed, 6 insertions(+)

Comments

Loic Poulain Feb. 11, 2024, 7:10 p.m. UTC | #1 
On Mon, 5 Feb 2024 at 11:23, Jinjian Song <songjinjian@hotmail.com> wrote:
>
> From: Jinjian Song <jinjian.song@fibocom.com>
>
> Add a new WWAN port that connects to the device fastboot protocol
> interface.
>
> Signed-off-by: Jinjian Song <jinjian.song@fibocom.com>

AFAIR, I already gave my tag for this change, please carry the tag
along versions.

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>



> ---
> v2-v9:
>  * no change
> ---
>  drivers/net/wwan/wwan_core.c | 4 ++++
>  include/linux/wwan.h         | 2 ++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 72e01e550a16..2ed20b20e7fc 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -328,6 +328,10 @@ static const struct {
>                 .name = "XMMRPC",
>                 .devsuf = "xmmrpc",
>         },
> +       [WWAN_PORT_FASTBOOT] = {
> +               .name = "FASTBOOT",
> +               .devsuf = "fastboot",
> +       },
>  };
>
>  static ssize_t type_show(struct device *dev, struct device_attribute *attr,
> diff --git a/include/linux/wwan.h b/include/linux/wwan.h
> index 01fa15506286..170fdee6339c 100644
> --- a/include/linux/wwan.h
> +++ b/include/linux/wwan.h
> @@ -16,6 +16,7 @@
>   * @WWAN_PORT_QCDM: Qcom Modem diagnostic interface
>   * @WWAN_PORT_FIREHOSE: XML based command protocol
>   * @WWAN_PORT_XMMRPC: Control protocol for Intel XMM modems
> + * @WWAN_PORT_FASTBOOT: Fastboot protocol control
>   *
>   * @WWAN_PORT_MAX: Highest supported port types
>   * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
> @@ -28,6 +29,7 @@ enum wwan_port_type {
>         WWAN_PORT_QCDM,
>         WWAN_PORT_FIREHOSE,
>         WWAN_PORT_XMMRPC,
> +       WWAN_PORT_FASTBOOT,
>
>         /* Add new port types above this line */
>
> --
> 2.34.1
>
Jinjian Song Feb. 19, 2024, 3:05 a.m. UTC | #2 
>On Mon, 5 Feb 2024 at 11:23, Jinjian Song <songjinjian@hotmail.com> wrote:
>>
>> From: Jinjian Song <jinjian.song@fibocom.com>
>>
>> Add a new WWAN port that connects to the device fastboot protocol
>> interface.
>>
>> Signed-off-by: Jinjian Song <jinjian.song@fibocom.com>
>
>AFAIR, I already gave my tag for this change, please carry the tag
>along versions.
>
>Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

Hi Loic,
Thanks for your guidance.
Sorry for that, is it possible to carry the tag now, I found this patch state
has changed to accepted.

>
>> ---
>> v2-v9:
>>  * no change
>> ---
>>  drivers/net/wwan/wwan_core.c | 4 ++++
>>  include/linux/wwan.h         | 2 ++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
>> index 72e01e550a16..2ed20b20e7fc 100644
>> --- a/drivers/net/wwan/wwan_core.c
>> +++ b/drivers/net/wwan/wwan_core.c
>> @@ -328,6 +328,10 @@ static const struct {
>>                 .name = "XMMRPC",
>>                 .devsuf = "xmmrpc",
>>         },
>> +       [WWAN_PORT_FASTBOOT] = {
>> +               .name = "FASTBOOT",
>> +               .devsuf = "fastboot",
>> +       },
>>  };
>>
>>  static ssize_t type_show(struct device *dev, struct device_attribute *attr,
>> diff --git a/include/linux/wwan.h b/include/linux/wwan.h
>> index 01fa15506286..170fdee6339c 100644
>> --- a/include/linux/wwan.h
>> +++ b/include/linux/wwan.h
>> @@ -16,6 +16,7 @@
>>   * @WWAN_PORT_QCDM: Qcom Modem diagnostic interface
>>   * @WWAN_PORT_FIREHOSE: XML based command protocol
>>   * @WWAN_PORT_XMMRPC: Control protocol for Intel XMM modems
>> + * @WWAN_PORT_FASTBOOT: Fastboot protocol control
>>   *
>>   * @WWAN_PORT_MAX: Highest supported port types
>>   * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
>> @@ -28,6 +29,7 @@ enum wwan_port_type {
>>         WWAN_PORT_QCDM,
>>         WWAN_PORT_FIREHOSE,
>>         WWAN_PORT_XMMRPC,
>> +       WWAN_PORT_FASTBOOT,
>>
>>         /* Add new port types above this line */
>>
>> --

Best Regards,
Jinjian
diff mbox series

Patch

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 72e01e550a16..2ed20b20e7fc 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -328,6 +328,10 @@  static const struct {
 		.name = "XMMRPC",
 		.devsuf = "xmmrpc",
 	},
+	[WWAN_PORT_FASTBOOT] = {
+		.name = "FASTBOOT",
+		.devsuf = "fastboot",
+	},
 };
 
 static ssize_t type_show(struct device *dev, struct device_attribute *attr,
diff --git a/include/linux/wwan.h b/include/linux/wwan.h
index 01fa15506286..170fdee6339c 100644
--- a/include/linux/wwan.h
+++ b/include/linux/wwan.h
@@ -16,6 +16,7 @@ 
  * @WWAN_PORT_QCDM: Qcom Modem diagnostic interface
  * @WWAN_PORT_FIREHOSE: XML based command protocol
  * @WWAN_PORT_XMMRPC: Control protocol for Intel XMM modems
+ * @WWAN_PORT_FASTBOOT: Fastboot protocol control
  *
  * @WWAN_PORT_MAX: Highest supported port types
  * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
@@ -28,6 +29,7 @@  enum wwan_port_type {
 	WWAN_PORT_QCDM,
 	WWAN_PORT_FIREHOSE,
 	WWAN_PORT_XMMRPC,
+	WWAN_PORT_FASTBOOT,
 
 	/* Add new port types above this line */