| Message ID | MW4PR17MB4243DA09E9168DB5B6675A52DFA70@MW4PR17MB4243.namprd17.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Subject: [PATCH v3 net-next 2/4] net:phy: Remove phy_reset_after_clk_enable() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 624 this patch: 378 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 37 lines checked |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 540 this patch: 294 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 80c2e646c093..13bae0ce31b8 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1798,30 +1798,6 @@ int phy_loopback(struct phy_device *phydev, bool enable) } EXPORT_SYMBOL(phy_loopback); -/** - * phy_reset_after_clk_enable - perform a PHY reset if needed - * @phydev: target phy_device struct - * - * Description: Some PHYs are known to need a reset after their refclk was - * enabled. This function evaluates the flags and perform the reset if it's - * needed. Returns < 0 on error, 0 if the phy wasn't reset and 1 if the phy - * was reset. - */ -int phy_reset_after_clk_enable(struct phy_device *phydev) -{ - if (!phydev || !phydev->drv) - return -ENODEV; - - if (phydev->drv->flags & PHY_RST_AFTER_CLK_EN) { - phy_device_reset(phydev, 1); - phy_device_reset(phydev, 0); - return 1; - } - - return 0; -} -EXPORT_SYMBOL(phy_reset_after_clk_enable); - /* Generic PHY support and helper functions */ /** diff --git a/include/linux/phy.h b/include/linux/phy.h index 9effb511acde..58b4a2d45df9 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1390,7 +1390,6 @@ int phy_speed_down(struct phy_device *phydev, bool sync); int phy_speed_up(struct phy_device *phydev); int phy_restart_aneg(struct phy_device *phydev); -int phy_reset_after_clk_enable(struct phy_device *phydev); #if IS_ENABLED(CONFIG_PHYLIB) int phy_start_cable_test(struct phy_device *phydev,
Extraneous PHY reset is not needed if the PHY is kept in reset when the REF_CLK is turned off, so remove phy_reset_after_clk_enable() which is not needed anymore. Signed-off-by: Laurent Badel <laurentbadel@eaton.com> --- drivers/net/phy/phy_device.c | 24 ------------------------ include/linux/phy.h | 1 - 2 files changed, 25 deletions(-)