| Message ID | PU4P216MB103753B46AF6597DAB78A4CBA2C82@PU4P216MB1037.KORP216.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: marvell: mvmdio: Add missing function argument name | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On 3/4/25 8:58 PM, Vinitha Vijayan wrote: > Fix a coding style issue in mvmdio.c where a function definition argument `struct orion_mdio_dev *` was missing an identifier name. This aligns with Linux kernel coding standards. > > Signed-off-by: Vinitha <vinithamvijayan723@gmail.com<mailto:vinithamvijayan723@gmail.com>> The patch does not apply, the commit message is not trimmed at 72 colums, and the SoB tag is mangled. More importantly, this kind of purely formal refactor should be part of larger/functional changes. I'm sorry, this patch is not going to be applied. Cheers, Paolo
diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index 3f4447e68888..91b7881ead03 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -86,7 +86,7 @@ enum orion_mdio_bus_type { }; struct orion_mdio_ops { - int (*is_done)(struct orion_mdio_dev *); + int (*is_done)(struct orion_mdio_dev *dev); }; /* Wait for the SMI unit to be ready for another operation
Fix a coding style issue in mvmdio.c where a function definition argument `struct orion_mdio_dev *` was missing an identifier name. This aligns with Linux kernel coding standards. Signed-off-by: Vinitha <vinithamvijayan723@gmail.com<mailto:vinithamvijayan723@gmail.com>> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1