| Message ID | Y+utT+5q5Te1GvYk@kili (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phy: Uninitialized variables in yt8531_link_change_notify() | expand |
On Tue, Feb 14, 2023 at 06:48:31PM +0300, Dan Carpenter wrote: > These booleans are never set to false, but are just used uninitialized. > > Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > Applies to net-next. > Sorry for sending this twice. :/ regards, dan carpenter
On 2023/2/14 23:48, Dan Carpenter wrote: > @@ -1534,9 +1534,9 @@ static void yt8531_link_change_notify(struct phy_device *phydev) > { > struct device_node *node = phydev->mdio.dev.of_node; > bool tx_clk_adj_enabled = false; > - bool tx_clk_1000_inverted; > - bool tx_clk_100_inverted; > - bool tx_clk_10_inverted; > + bool tx_clk_1000_inverted = false; > + bool tx_clk_100_inverted = false; > + bool tx_clk_10_inverted = false; Thanks, please keep reverse christmas tree. > u16 val = 0; > int ret; >
On Wed, Feb 15, 2023 at 09:51:56AM +0800, Frank Sae wrote: > > > On 2023/2/14 23:48, Dan Carpenter wrote: > > > @@ -1534,9 +1534,9 @@ static void yt8531_link_change_notify(struct phy_device *phydev) > > { > > struct device_node *node = phydev->mdio.dev.of_node; > > bool tx_clk_adj_enabled = false; > > - bool tx_clk_1000_inverted; > > - bool tx_clk_100_inverted; > > - bool tx_clk_10_inverted; > > + bool tx_clk_1000_inverted = false; > > + bool tx_clk_100_inverted = false; > > + bool tx_clk_10_inverted = false; > > Thanks, please keep reverse christmas tree. > Right. Good point. regards, dan carpenter
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index ee7c37dfdca0..119a54d6c65d 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1534,9 +1534,9 @@ static void yt8531_link_change_notify(struct phy_device *phydev) { struct device_node *node = phydev->mdio.dev.of_node; bool tx_clk_adj_enabled = false; - bool tx_clk_1000_inverted; - bool tx_clk_100_inverted; - bool tx_clk_10_inverted; + bool tx_clk_1000_inverted = false; + bool tx_clk_100_inverted = false; + bool tx_clk_10_inverted = false; u16 val = 0; int ret;
These booleans are never set to false, but are just used uninitialized. Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy") Signed-off-by: Dan Carpenter <error27@gmail.com> --- Applies to net-next. drivers/net/phy/motorcomm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)