| Message ID | Y+xd2yJet2ImHLoQ@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9753613f7399601f9bae6ee81e9d4274246c98ab |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify() | expand |
On 2023/2/15 12:21, Dan Carpenter wrote: > These booleans are never set to false, but are just used without being > initialized. > > Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > v2: reverse Christmas tree. Also add "motorcomm" to the subject. It > really feels like previous patches to this driver should have had > motorcomm in the subject as well. It's a common anti-pattern to only > put the subsystem name and not the driver name when adding a new file. > > drivers/net/phy/motorcomm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c > index ee7c37dfdca0..2fa5a90e073b 100644 > --- a/drivers/net/phy/motorcomm.c > +++ b/drivers/net/phy/motorcomm.c > @@ -1533,10 +1533,10 @@ static int yt8531_config_init(struct phy_device *phydev) > static void yt8531_link_change_notify(struct phy_device *phydev) > { > struct device_node *node = phydev->mdio.dev.of_node; > + bool tx_clk_1000_inverted = false; > + bool tx_clk_100_inverted = false; > + bool tx_clk_10_inverted = false; > bool tx_clk_adj_enabled = false; > - bool tx_clk_1000_inverted; > - bool tx_clk_100_inverted; > - bool tx_clk_10_inverted; > u16 val = 0; > int ret; > Reviewed-by: Frank Sae <Frank.Sae@motor-comm.com> Add cc.
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 15 Feb 2023 07:21:47 +0300 you wrote: > These booleans are never set to false, but are just used without being > initialized. > > Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy") > Signed-off-by: Dan Carpenter <error27@gmail.com> > --- > v2: reverse Christmas tree. Also add "motorcomm" to the subject. It > really feels like previous patches to this driver should have had > motorcomm in the subject as well. It's a common anti-pattern to only > put the subsystem name and not the driver name when adding a new file. > > [...] Here is the summary with links: - [v2,net-next] net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify() https://git.kernel.org/netdev/net-next/c/9753613f7399 You are awesome, thank you!
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index ee7c37dfdca0..2fa5a90e073b 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -1533,10 +1533,10 @@ static int yt8531_config_init(struct phy_device *phydev) static void yt8531_link_change_notify(struct phy_device *phydev) { struct device_node *node = phydev->mdio.dev.of_node; + bool tx_clk_1000_inverted = false; + bool tx_clk_100_inverted = false; + bool tx_clk_10_inverted = false; bool tx_clk_adj_enabled = false; - bool tx_clk_1000_inverted; - bool tx_clk_100_inverted; - bool tx_clk_10_inverted; u16 val = 0; int ret;
These booleans are never set to false, but are just used without being initialized. Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy") Signed-off-by: Dan Carpenter <error27@gmail.com> --- v2: reverse Christmas tree. Also add "motorcomm" to the subject. It really feels like previous patches to this driver should have had motorcomm in the subject as well. It's a common anti-pattern to only put the subsystem name and not the driver name when adding a new file. drivers/net/phy/motorcomm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)