| Message ID | Y0lzHssyY3VkxuAz@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9408f3d321ed2286b9722bceff08ca28b741c026 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] sunhme: Uninitialized variable in happy_meal_init() | expand |
On 10/14/22 10:33, Dan Carpenter wrote: > The "burst" string is only initialized for CONFIG_SPARC. It should be > set to "64" because that's what is used by PCI. > > Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: Use "64" instead of "" > > drivers/net/ethernet/sun/sunhme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c > index 62deed210a95..55f7ec836744 100644 > --- a/drivers/net/ethernet/sun/sunhme.c > +++ b/drivers/net/ethernet/sun/sunhme.c > @@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp) > void __iomem *erxregs = hp->erxregs; > void __iomem *bregs = hp->bigmacregs; > void __iomem *tregs = hp->tcvregs; > - const char *bursts; > + const char *bursts = "64"; > u32 regtmp, rxcfg; > > /* If auto-negotiation timer is running, kill it. */ Reviewed-by: Sean Anderson <seanga2@gmail.com>
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 14 Oct 2022 17:33:02 +0300 you wrote: > The "burst" string is only initialized for CONFIG_SPARC. It should be > set to "64" because that's what is used by PCI. > > Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: Use "64" instead of "" > > [...] Here is the summary with links: - [net,v2] sunhme: Uninitialized variable in happy_meal_init() https://git.kernel.org/netdev/net/c/9408f3d321ed You are awesome, thank you!
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c index 62deed210a95..55f7ec836744 100644 --- a/drivers/net/ethernet/sun/sunhme.c +++ b/drivers/net/ethernet/sun/sunhme.c @@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp) void __iomem *erxregs = hp->erxregs; void __iomem *bregs = hp->bigmacregs; void __iomem *tregs = hp->tcvregs; - const char *bursts; + const char *bursts = "64"; u32 regtmp, rxcfg; /* If auto-negotiation timer is running, kill it. */
The "burst" string is only initialized for CONFIG_SPARC. It should be set to "64" because that's what is used by PCI. Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: Use "64" instead of "" drivers/net/ethernet/sun/sunhme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)