| Message ID | YCy0tPmgaHL1U2Le@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c77662605d8d715062f15bbf567b5a61082b4967 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] cteontx2-pf: cn10k: Prevent harmless double shift bugs | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 12 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 14 this patch: 14 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 09:16:20 +0300 you wrote: > These defines are used with set_bit() and test_bit() which take a bit > number. In other words, the code is doing: > > if (BIT(BIT(1)) & pf->hw.cap_flag) { > > This was done consistently so it did not cause a problem at runtime but > it's still worth fixing. > > [...] Here is the summary with links: - [net-next] cteontx2-pf: cn10k: Prevent harmless double shift bugs https://git.kernel.org/netdev/net-next/c/c77662605d8d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h index 4c472646a0ac..19aef37b8ef9 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h @@ -210,9 +210,9 @@ struct otx2_hw { u64 cgx_fec_uncorr_blks; u8 cgx_links; /* No. of CGX links present in HW */ u8 lbk_links; /* No. of LBK links present in HW */ -#define HW_TSO BIT_ULL(0) -#define CN10K_MBOX BIT_ULL(1) -#define CN10K_LMTST BIT_ULL(2) +#define HW_TSO 0 +#define CN10K_MBOX 1 +#define CN10K_LMTST 2 unsigned long cap_flag; #define LMT_LINE_SIZE 128
These defines are used with set_bit() and test_bit() which take a bit number. In other words, the code is doing: if (BIT(BIT(1)) & pf->hw.cap_flag) { This was done consistently so it did not cause a problem at runtime but it's still worth fixing. Fixes: facede8209ef ("octeontx2-pf: cn10k: Add mbox support for CN10K") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)