| Message ID | YIqTHAq37U57ehAa@mwanda (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] net/mlx5: net/mlx5: Fix some error messages | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: davem@davemloft.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 37 this patch: 37 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 30 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 30 this patch: 30 |
| netdev/header_inline | success | Link |
On Thu, Apr 29, 2021 at 02:06:04PM +0300, Dan Carpenter wrote: > This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead > of the correct error code. Even better would be to use %pe which prints > out the name of the error, as in "ENOMEM", "EINVAL" etc. > > Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: Use %pe instead of %ld. > > Leon says this goes through netdev instead of the RDMA tree. Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c index a81ece94f599..a0efb19bf285 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct mlx5_core_dev *dev, ft_attr.autogroup.max_num_groups = 1; tt->termtbl = mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr); if (IS_ERR(tt->termtbl)) { - esw_warn(dev, "Failed to create termination table (error %d)\n", - IS_ERR(tt->termtbl)); + esw_warn(dev, "Failed to create termination table (error %pe)\n", + tt->termtbl); return -EOPNOTSUPP; } tt->rule = mlx5_add_flow_rules(tt->termtbl, NULL, flow_act, &tt->dest, 1); if (IS_ERR(tt->rule)) { - esw_warn(dev, "Failed to create termination table rule (error %d)\n", - IS_ERR(tt->rule)); + esw_warn(dev, "Failed to create termination table rule (error %pe)\n", + tt->rule); goto add_flow_err; } return 0; @@ -283,8 +283,8 @@ mlx5_eswitch_add_termtbl_rule(struct mlx5_eswitch *esw, tt = mlx5_eswitch_termtbl_get_create(esw, &term_tbl_act, &dest[i], attr); if (IS_ERR(tt)) { - esw_warn(esw->dev, "Failed to get termination table (error %d)\n", - IS_ERR(tt)); + esw_warn(esw->dev, "Failed to get termination table (error %pe)\n", + tt); goto revert_changes; } attr->dests[num_vport_dests].termtbl = tt;
This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead of the correct error code. Even better would be to use %pe which prints out the name of the error, as in "ENOMEM", "EINVAL" etc. Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: Use %pe instead of %ld. Leon says this goes through netdev instead of the RDMA tree. .../mellanox/mlx5/core/eswitch_offloads_termtbl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)