| Message ID | YM32HV7psa+PrmbV@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1a1100d53f12451d50bc5ebbc941517760912ab8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 20 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 19/06/2021 15:50, Dan Carpenter wrote: > These functions return negative ENODATA but the minus sign was left out > in the tests. > > Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > net/smc/smc_stats.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/smc/smc_stats.c b/net/smc/smc_stats.c > index 614013e3b574..e80e34f7ac15 100644 > --- a/net/smc/smc_stats.c > +++ b/net/smc/smc_stats.c > @@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb) > continue; > if (!skip_serv) { > rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv); > - if (rc_srv && rc_srv != ENODATA) > + if (rc_srv && rc_srv != -ENODATA) > break; > } else { > skip_serv = 0; > } > rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv); > - if (rc_clnt && rc_clnt != ENODATA) { > + if (rc_clnt && rc_clnt != -ENODATA) { > skip_serv = 1; > break; > } > - if (rc_clnt == ENODATA && rc_srv == ENODATA) > + if (rc_clnt == -ENODATA && rc_srv == -ENODATA) > break; > } > mutex_unlock(&net->smc.mutex_fback_rsn); Acked-by: Guvenc Gulce <guvenc@linux.ibm.com> Thanks for preparing the fix.
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 19 Jun 2021 16:50:21 +0300 you wrote: > These functions return negative ENODATA but the minus sign was left out > in the tests. > > Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > net/smc/smc_stats.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Here is the summary with links: - [net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats() https://git.kernel.org/netdev/net-next/c/1a1100d53f12 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/smc/smc_stats.c b/net/smc/smc_stats.c index 614013e3b574..e80e34f7ac15 100644 --- a/net/smc/smc_stats.c +++ b/net/smc/smc_stats.c @@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb) continue; if (!skip_serv) { rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv); - if (rc_srv && rc_srv != ENODATA) + if (rc_srv && rc_srv != -ENODATA) break; } else { skip_serv = 0; } rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv); - if (rc_clnt && rc_clnt != ENODATA) { + if (rc_clnt && rc_clnt != -ENODATA) { skip_serv = 1; break; } - if (rc_clnt == ENODATA && rc_srv == ENODATA) + if (rc_clnt == -ENODATA && rc_srv == -ENODATA) break; } mutex_unlock(&net->smc.mutex_fback_rsn);
These functions return negative ENODATA but the minus sign was left out in the tests. Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/smc/smc_stats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)