| Message ID | YMCP1wJ6+e2E1n4m@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 711d1dee1c86294b43e33202fb1eabd7e524ed9a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] devlink: Fix error message in devlink_rate_set_ops_supported() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 9 Jun 2021 12:54:31 +0300 you wrote: > The WARN_ON() macro takes a condition, it doesn't take a message. Use > WARN() instead. > > Fixes: 1897db2ec310 ("devlink: Allow setting tx rate for devlink rate leaf objects") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > net/core/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] devlink: Fix error message in devlink_rate_set_ops_supported() https://git.kernel.org/netdev/net-next/c/711d1dee1c86 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/core/devlink.c b/net/core/devlink.c index 1e953b77a77a..4a5b333c05a0 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -1732,7 +1732,7 @@ static bool devlink_rate_set_ops_supported(const struct devlink_ops *ops, return false; } } else { - WARN_ON("Unknown type of rate object"); + WARN(1, "Unknown type of rate object"); return false; }
The WARN_ON() macro takes a condition, it doesn't take a message. Use WARN() instead. Fixes: 1897db2ec310 ("devlink: Allow setting tx rate for devlink rate leaf objects") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)