| Message ID | YzX+nzJolxAKmt+z@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 70d5ab532059f06c2833b0e4ffae8a785c3692df |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: nfc: marvell,nci: fix reset line polarity in examples | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 29/09/2022 22:22, Dmitry Torokhov wrote: > The reset line is supposed to be "active low" (it even says so in the > description), but examples incorrectly show it as "active high" > (likely because original examples use 0 which is technically "active > high" but in practice often "don't care" if the driver is using legacy > gpio API, as this one does). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 29 Sep 2022 13:22:55 -0700 you wrote: > The reset line is supposed to be "active low" (it even says so in the > description), but examples incorrectly show it as "active high" > (likely because original examples use 0 which is technically "active > high" but in practice often "don't care" if the driver is using legacy > gpio API, as this one does). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > [...] Here is the summary with links: - dt-bindings: nfc: marvell,nci: fix reset line polarity in examples https://git.kernel.org/netdev/net-next/c/70d5ab532059 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml b/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml index a191a04e681c..308485a8ee6c 100644 --- a/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml +++ b/Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml @@ -128,7 +128,7 @@ examples: i2c-int-rising; - reset-n-io = <&gpio3 19 GPIO_ACTIVE_HIGH>; + reset-n-io = <&gpio3 19 GPIO_ACTIVE_LOW>; }; }; @@ -151,7 +151,7 @@ examples: interrupt-parent = <&gpio1>; interrupts = <17 IRQ_TYPE_EDGE_RISING>; - reset-n-io = <&gpio3 19 GPIO_ACTIVE_HIGH>; + reset-n-io = <&gpio3 19 GPIO_ACTIVE_LOW>; }; }; @@ -162,7 +162,7 @@ examples: nfc { compatible = "marvell,nfc-uart"; - reset-n-io = <&gpio3 16 GPIO_ACTIVE_HIGH>; + reset-n-io = <&gpio3 16 GPIO_ACTIVE_LOW>; hci-muxed; flow-control;
The reset line is supposed to be "active low" (it even says so in the description), but examples incorrectly show it as "active high" (likely because original examples use 0 which is technically "active high" but in practice often "don't care" if the driver is using legacy gpio API, as this one does). Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- Documentation/devicetree/bindings/net/nfc/marvell,nci.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)