| Message ID | Z3aJccb1vW14aukg@pidgin.makrotopia.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a003c38d9bbbacd26b2354795bddb8d25631b0b5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 2 Jan 2025 12:41:21 +0000 you wrote: > Neither does the LynxI PCS support QSGMII, nor is in-band-status supported > in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly. > > Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method") > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities https://git.kernel.org/netdev/net-next/c/a003c38d9bbb You are awesome, thank you!
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c index 7de804535229..ed91cd7a406a 100644 --- a/drivers/net/pcs/pcs-mtk-lynxi.c +++ b/drivers/net/pcs/pcs-mtk-lynxi.c @@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs, { switch (interface) { case PHY_INTERFACE_MODE_1000BASEX: - case PHY_INTERFACE_MODE_2500BASEX: case PHY_INTERFACE_MODE_SGMII: - case PHY_INTERFACE_MODE_QSGMII: return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE; + case PHY_INTERFACE_MODE_2500BASEX: + return LINK_INBAND_DISABLE; + default: return 0; }
Neither does the LynxI PCS support QSGMII, nor is in-band-status supported in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly. Fixes: 520d29bdda86 ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method") Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/net/pcs/pcs-mtk-lynxi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)