| Message ID | ZFWIpN7HN431MVSI@slm.duckdns.org (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Fri, 2023-05-05 at 12:52 -1000, Tejun Heo wrote: > trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need > explicit concurrency limit. Let's use the default @max_active. This doesn't > cost anything and clearly expresses that @max_active doesn't matter. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Gregory Greenman <gregory.greenman@intel.com> > Cc: Johannes Berg <johannes.berg@intel.com> > Cc: Avraham Stern <avraham.stern@intel.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Mordechay Goodstein <mordechay.goodstein@intel.com> > Cc: "Haim, Dreyfuss" <haim.dreyfuss@intel.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Sure, that seems fine too. Acked-by: Johannes Berg <johannes.berg@intel.com> For whatever that's worth, might better to get Gregory ;-) johannes > --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c > +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c > @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s > init_waitqueue_head(&trans_pcie->imr_waitq); > > trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator", > - WQ_HIGHPRI | WQ_UNBOUND, 1); > + WQ_HIGHPRI | WQ_UNBOUND, 0); > if (!trans_pcie->rba.alloc_wq) { > ret = -ENOMEM; > goto out_free_trans; >
--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s init_waitqueue_head(&trans_pcie->imr_waitq); trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator", - WQ_HIGHPRI | WQ_UNBOUND, 1); + WQ_HIGHPRI | WQ_UNBOUND, 0); if (!trans_pcie->rba.alloc_wq) { ret = -ENOMEM; goto out_free_trans;
trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need explicit concurrency limit. Let's use the default @max_active. This doesn't cost anything and clearly expresses that @max_active doesn't matter. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Kalle Valo <kvalo@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Gregory Greenman <gregory.greenman@intel.com> Cc: Johannes Berg <johannes.berg@intel.com> Cc: Avraham Stern <avraham.stern@intel.com> Cc: Kees Cook <keescook@chromium.org> Cc: Mordechay Goodstein <mordechay.goodstein@intel.com> Cc: "Haim, Dreyfuss" <haim.dreyfuss@intel.com> Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org --- Hello, Johannes, do you mind acking this patch instead? Thanks. drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)