| Message ID | Z_-P_1iLDWksH1ik@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode_ticket() | expand |
On Wed, Apr 16, 2025 at 02:09:51PM +0300, Dan Carpenter wrote: > Propagate the error code if key_alloc() fails. Don't return > success. > > Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org> ... > diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c > index 6206a84395b8..b94b77a1c317 100644 > --- a/net/rxrpc/rxgk_app.c > +++ b/net/rxrpc/rxgk_app.c > @@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb, > KEY_ALLOC_NOT_IN_QUOTA, NULL); > if (IS_ERR(key)) { > _leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key)); Not a bug, but it doesn't seem ideal that _leave(), which logs a debug message, is called here and with a more general format in the error label. > + ret = PTR_ERR(key); > goto error; > } > > -- > 2.47.2 >
diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c index 6206a84395b8..b94b77a1c317 100644 --- a/net/rxrpc/rxgk_app.c +++ b/net/rxrpc/rxgk_app.c @@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb, KEY_ALLOC_NOT_IN_QUOTA, NULL); if (IS_ERR(key)) { _leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key)); + ret = PTR_ERR(key); goto error; }
Propagate the error code if key_alloc() fails. Don't return success. Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- It's not totally clear if these patch prefixes are real things or just a cat walking across the keyboard. "rxrxpc: gk: yfs-rxgk" Really? We expect people to believe these are real? --- net/rxrpc/rxgk_app.c | 1 + 1 file changed, 1 insertion(+)