From patchwork Wed Mar 27 19:36:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 13607350 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C59380 for ; Wed, 27 Mar 2024 19:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711568191; cv=none; b=neY4qHSYbQhAx0iEHhuwLl3X1pSX/EpMApLRZUTyeRxTFB53yExDpLSAcaspf3EwGORo6mgy6cbUJT31NieQ80nFFW4CY+ppyAAlL2HD1/Anj6HNtfyazCQfkICdlJmovl7XWGDjmRHWK+891+sOxCO1pMiMeEiLFAfkcMM9VTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711568191; c=relaxed/simple; bh=QfXzi0YNDFsvO8OTu50pvn3hzJPM8ReXHZFLA98loos=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=qT3nd9pW8XSj2yJfBacQOfr11502aQPVX7zUb+GAtxLm29UnT1l8tvt0UbSTctMSJ1DnWRN2DPlypdmP8HZWghpEC67BgUjkSrfH3vozRAU+ooj8s6BQl/sTSun6lgW7goBnNb4YDdDvNBCX4uMXBJUXNUMCgwK2xsMk1hlK008= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a0tBNGNW; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a0tBNGNW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711568188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=RNzpMpe3zjcO2rv2cPTPhLNPeQGeEirCU3wKPzNxR/w=; b=a0tBNGNWJWLeNh5C/IMufKuzU3+VdchVZueLOtD6dFVAQ23s6pkt9LGyhxEMtWlJBM18VA hVpq0AvsU3CX5o0k+lFnL5PPCia6WXJz85E+/BNfXZxqtgRrercsdGUR9EAQ6a63pUr+ri ZhF3qacrB/DUtPGoRhUlEi0LsihxzO0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-uVMlZZbbNb6l0MVBaSbpvQ-1; Wed, 27 Mar 2024 15:36:25 -0400 X-MC-Unique: uVMlZZbbNb6l0MVBaSbpvQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F03FD3801FE1; Wed, 27 Mar 2024 19:36:24 +0000 (UTC) Received: from tpad.localdomain (unknown [10.96.133.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FB6F1C060D0; Wed, 27 Mar 2024 19:36:24 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 9C4EC4210057A; Wed, 27 Mar 2024 16:36:04 -0300 (-03) Date: Wed, 27 Mar 2024 16:36:04 -0300 From: Marcelo Tosatti To: netdev@vger.kernel.org Cc: Willem de Bruijn , Jakub Kicinski , Eric Dumazet , Frederic Weisbecker , Valentin Schneider , Paolo Abeni Subject: net: enable timestamp static key if CPU isolation is configured Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 For systems that use CPU isolation (via nohz_full), creating or destroying a socket with SO_TIMESTAMP, SO_TIMESTAMPNS or SO_TIMESTAMPING with flag SOF_TIMESTAMPING_RX_SOFTWARE will cause a static key to be enabled/disabled. This in turn causes undesired IPIs to isolated CPUs. So enable the static key unconditionally, if CPU isolation is enabled, thus avoiding the IPIs. Signed-off-by: Marcelo Tosatti --- v2: mention SOF_TIMESTAMPING_OPT_TX_SWHW in the commit log (Willem de Bruijn / Paolo Abeni) v3: SOF_TIMESTAMPING_OPT_TX_SWHW is irrelevant (Willem de Bruijn) v4: additional changelog improvements (Willem de Bruijn) v5: late initcall not necessary, can use subsys initcall (Willem de Bruijn) v6: rebase against net-next, change subject (Jakub Kicinski) diff --git a/net/core/dev.c b/net/core/dev.c index 5d36a634f468..48c725caa130 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -157,6 +157,7 @@ #include #include #include +#include #include "dev.h" #include "net-sysfs.h" @@ -11890,6 +11891,10 @@ static int __init net_dev_init(void) NULL, dev_cpu_dead); WARN_ON(rc < 0); rc = 0; + + /* avoid static key IPIs to isolated CPUs */ + if (housekeeping_enabled(HK_TYPE_MISC)) + net_enable_timestamp(); out: if (rc < 0) { for_each_possible_cpu(i) {