diff mbox series

xen-netback: Use seq_putc() in xenvif_dump_hash_info()

Message ID add2bb00-4ac1-485d-839a-55670e2c7915@web.de (mailing list archive)
State Deferred
Delegated to: Netdev Maintainers
Headers show
Series xen-netback: Use seq_putc() in xenvif_dump_hash_info() | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 816 this patch: 816
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 821 this patch: 821
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 821 this patch: 821
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-07-14--09-00 (tests: 696)

Commit Message

Markus Elfring July 13, 2024, 1:18 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jul 2024 15:10:15 +0200

Single characters (line breaks) should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/xen-netback/hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.45.2

Comments

Jakub Kicinski July 15, 2024, 4:01 p.m. UTC | #1 
On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
> Single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function “seq_putc”.
> 
> This issue was transformed by using the Coccinelle software.

I prefer to only merge trivial changes like this if maintainer
indicates their support by acking them. Since the merge window
has opened we can't wait and see so I'm marking this patch and
your pktgen patch as deferred.
Christophe JAILLET July 15, 2024, 8:24 p.m. UTC | #2 
Le 15/07/2024 à 18:01, Jakub Kicinski a écrit :
> On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
>> Single characters (line breaks) should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
> 
> I prefer to only merge trivial changes like this if maintainer
> indicates their support by acking them. Since the merge window
> has opened we can't wait and see so I'm marking this patch and
> your pktgen patch as deferred.
> 
> 

Hi Jakub,

Most of the time, this kind of modification is useless because it is 
already done by the compiler, see [1].

CJ

[1]: 
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/seq_file.h#L123
Jakub Kicinski July 15, 2024, 8:39 p.m. UTC | #3 
On Mon, 15 Jul 2024 22:24:39 +0200 Christophe JAILLET wrote:
> Most of the time, this kind of modification is useless because it is 
> already done by the compiler, see [1].

GTK, thanks!
diff mbox series

Patch

diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-netback/hash.c
index ff96f22648ef..2d77a7187e1e 100644
--- a/drivers/net/xen-netback/hash.c
+++ b/drivers/net/xen-netback/hash.c
@@ -425,7 +425,7 @@  void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
 		for (j = 0; j < n; j++, i++)
 			seq_printf(m, "%02x ", vif->hash.key[i]);

-		seq_puts(m, "\n");
+		seq_putc(m, '\n');
 	}

 	if (vif->hash.size != 0) {
@@ -445,7 +445,7 @@  void xenvif_dump_hash_info(struct xenvif *vif, struct seq_file *m)
 			for (j = 0; j < n; j++, i++)
 				seq_printf(m, "%4u ", mapping[i]);

-			seq_puts(m, "\n");
+			seq_putc(m, '\n');
 		}
 	}
 }