diff mbox series

dsa: fix for_each_child.cocci warnings

Message ID alpine.DEB.2.22.394.2107111810480.13622@hadrien (mailing list archive)
State Accepted
Commit 84f7e0bb4809f4497124b6b6904c07c8a0c73c58
Delegated to: Netdev Maintainers
Headers show
Series dsa: fix for_each_child.cocci warnings | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Julia Lawall July 11, 2021, 4:12 p.m. UTC 
From: kernel test robot <lkp@intel.com>

For_each_available_child_of_node should have of_node_put() before
return around line 423.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago

 ksz_common.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 11, 2021, 5:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
> From: kernel test robot <lkp@intel.com>
> 
> For_each_available_child_of_node should have of_node_put() before
> return around line 423.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> [...]

Here is the summary with links:
  - dsa: fix for_each_child.cocci warnings
    https://git.kernel.org/netdev/net/c/84f7e0bb4809

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Florian Fainelli July 11, 2021, 9:20 p.m. UTC | #2 
On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (refs/heads/master):
> 
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
> 
> Here is the summary with links:
>    - dsa: fix for_each_child.cocci warnings
>      https://git.kernel.org/netdev/net/c/84f7e0bb4809

The patch subject should have been:

net: dsa: microchip: fix for_each_child.cocci warning

(singular, not plural), yes I like to paint my bike shed blue.
--
Florian
diff mbox series

Patch

--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -419,8 +419,10 @@  int ksz_switch_register(struct ksz_devic
 				if (of_property_read_u32(port, "reg",
 							 &port_num))
 					continue;
-				if (!(dev->port_mask & BIT(port_num)))
+				if (!(dev->port_mask & BIT(port_num))) {
+					of_node_put(port);
 					return -EINVAL;
+				}
 				of_get_phy_mode(port,
 						&dev->ports[port_num].interface);
 			}