From patchwork Tue Sep 12 08:28:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 13381044 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7989463 for ; Tue, 12 Sep 2023 08:28:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E181CC433C7; Tue, 12 Sep 2023 08:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694507290; bh=5qB4UhHNxlfdEU26lBim86iImVIY5x6356pApSHcaJ0=; h=From:To:Cc:Subject:Date:From; b=bP2pvNEP5pqMG2K0uyFOWp54lYCcQk39Lm2/WTZx4VB1jthaF3gHWo+jHC6BNp1Nn x0wAZ+Unko6TKuIrnCLkNgkt3tz2DyFhCystl0Cft1j/PM5Jh4yH2ofYYLRc5k/tvF 5OSNtx4eaYStqp0AP+tWFFeOgznXSpS3W9hk0VutneldjRaLtq8EdpBCvfPm8MVM8/ b5YbVCfDiFk/gViGGXgsLiNxIgOt83TA6v7wB5CKdE2hU5lcPb4y/+qarYCz3vMwyR 1Esc/pwyASkSz4KjTu9Feqk9jByIULJ96/5fZElQusF3qkR7mcg872b7e0yJDX7rpL hlmoS3IWhd5Ug== From: Lorenzo Bianconi To: netdev@vger.kernel.org Cc: lorenzo.bianconi@redhat.com, nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Subject: [PATCH net-next] net: ethernet: mtk_wed: check update_wo_rx_stats in mtk_wed_update_rx_stats() Date: Tue, 12 Sep 2023 10:28:00 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Check if update_wo_rx_stats function pointer is properly set in mtk_wed_update_rx_stats routine before accessing it. Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman --- drivers/net/ethernet/mediatek/mtk_wed_mcu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_wed_mcu.c b/drivers/net/ethernet/mediatek/mtk_wed_mcu.c index 071ed3dea860..72bcdaed12a9 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed_mcu.c +++ b/drivers/net/ethernet/mediatek/mtk_wed_mcu.c @@ -68,6 +68,9 @@ mtk_wed_update_rx_stats(struct mtk_wed_device *wed, struct sk_buff *skb) struct mtk_wed_wo_rx_stats *stats; int i; + if (!wed->wlan.update_wo_rx_stats) + return; + if (count * sizeof(*stats) > skb->len - sizeof(u32)) return;