| Message ID | b64d9f86-d029-b911-bbe9-6ca6889399d7@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 513bdd9473888ba4b1441923c2711cb5ecd06cfd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phy: smsc: use phy_set_bits in smsc_phy_config_init | expand |
On Wed, Mar 08, 2023 at 09:19:55PM +0100, Heiner Kallweit wrote: > Simplify the code by using phy_set_bits(). > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 8 Mar 2023 21:19:55 +0100 you wrote: > Simplify the code by using phy_set_bits(). > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/phy/smsc.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) Here is the summary with links: - [net-next] net: phy: smsc: use phy_set_bits in smsc_phy_config_init https://git.kernel.org/netdev/net-next/c/513bdd947388 You are awesome, thank you!
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 5965a8afa..630104c16 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -107,20 +107,13 @@ static irqreturn_t smsc_phy_handle_interrupt(struct phy_device *phydev) static int smsc_phy_config_init(struct phy_device *phydev) { struct smsc_phy_priv *priv = phydev->priv; - int rc; if (!priv->energy_enable || phydev->irq != PHY_POLL) return 0; - rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS); - - if (rc < 0) - return rc; - - /* Enable energy detect mode for this SMSC Transceivers */ - rc = phy_write(phydev, MII_LAN83C185_CTRL_STATUS, - rc | MII_LAN83C185_EDPWRDOWN); - return rc; + /* Enable energy detect power down mode */ + return phy_set_bits(phydev, MII_LAN83C185_CTRL_STATUS, + MII_LAN83C185_EDPWRDOWN); } static int smsc_phy_reset(struct phy_device *phydev)
Simplify the code by using phy_set_bits(). Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/smsc.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)