| Message ID | c1bab067-00ba-f6b5-f683-709f1d5b09a9@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 09ae03e2fc9d04240c21759ce9f1ef63d7651850 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] stmmac: remove ethtool driver version info | expand |
On Sun, Nov 28, 2021 at 07:45:56PM +0100, Heiner Kallweit wrote: > I think there's no benefit in reporting a date from almost 6 yrs ago. > Let ethtool report the default (kernel version) instead. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 28 Nov 2021 19:45:56 +0100 you wrote: > I think there's no benefit in reporting a date from almost 6 yrs ago. > Let ethtool report the default (kernel version) instead. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 - > drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 - > 2 files changed, 2 deletions(-) Here is the summary with links: - [net-next] stmmac: remove ethtool driver version info https://git.kernel.org/netdev/net-next/c/09ae03e2fc9d You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 689f3cdb2..4f5292cad 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h @@ -10,7 +10,6 @@ #define __STMMAC_H__ #define STMMAC_RESOURCE_NAME "stmmaceth" -#define DRV_MODULE_VERSION "Jan_2016" #include <linux/clk.h> #include <linux/hrtimer.h> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index eead45369..164dff5ec 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -290,7 +290,6 @@ static void stmmac_ethtool_getdrvinfo(struct net_device *dev, strlcpy(info->bus_info, pci_name(priv->plat->pdev), sizeof(info->bus_info)); } - strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version)); } static int stmmac_ethtool_get_link_ksettings(struct net_device *dev,
I think there's no benefit in reporting a date from almost 6 yrs ago. Let ethtool report the default (kernel version) instead. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 - drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 - 2 files changed, 2 deletions(-)