From patchwork Sun Jan 19 07:27:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 13944359 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1638143888; Sun, 19 Jan 2025 07:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737271690; cv=none; b=VZF96ivak1UYNn9n8LwV2S1jCQx5M6l9ahRJc1f29rTwTawR96Y6ONCLehfYBfuQM7IUs9Rl2spUmUophKgrSYR6VLvBZjA6LD7SjlLR2e26Md9eFlX2/GqA6w3kGJ+GoTAwcLzPfFn0MCwmq+fyoELMBFjexIoLYuB1EOGRJzQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737271690; c=relaxed/simple; bh=vyuqq862oTZFHsXsWE32eHjyKNnZNBjzLLQ1+k0W1yA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kXtmHW9QXRK2HiY+LFkLIqQrV/QKY62kIoU5H+GMxC1POi0eg23MmJOemcw2V/3qsqMu291JEIYXQWPv6cSUYtnDBEKSt5QfUSEv9NBGW65lazOZajgGuiniBIwofkkv4hOLMI8j2TNGSg63BIFXM9mCDSuZjNLv/RPQKGyiXaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hiBYwuzW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hiBYwuzW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB621C4CED6; Sun, 19 Jan 2025 07:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737271689; bh=vyuqq862oTZFHsXsWE32eHjyKNnZNBjzLLQ1+k0W1yA=; h=From:To:Cc:Subject:Date:From; b=hiBYwuzW9awygvQMjoTkoB15QUXgn2LxPEfi3HQWH0qSrEXE0UJEQ3IVSWnho/gsV G6o4xJV7JGilKdTR8JFfHXmu9n7JPYDjFmZ57ZtwYsFh1ZJeKK1JqC3J3j6kVMgwHn mqaxXr/ow2q/Z76g1z9Sf9PKuyYXDFvPlfg2IHGzOWStI1ZPfIu/6bij2lJJB2u1Z4 D+vGC3+HC5tsOuavbK3ZGyLY1o6joXmAmckMcEVeW42v+jt+gdpsSx5qeipL/KvCRc 6BCkiqJHk5lum83VNXiRj+Q9cwxpLNG1w7PEqtP+wZzVBBBClCBjC5xcWAooFTEqDO KKCfUXarGIL+Q== From: Leon Romanovsky To: Cc: Leon Romanovsky , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, Ariel Almog , Aditya Prabhune , Hannes Reinecke , Heiner Kallweit , Arun Easi , Jonathan Chocron , Bert Kenward , Matt Carlson , Kai-Heng Feng , Jean Delvare , Alex Williamson , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , =?utf-8?q?Thomas_?= =?utf-8?q?Wei=C3=9Fschuh?= , Stephen Hemminger Subject: [PATCH v4] PCI/sysfs: Change read permissions for VPD attributes Date: Sun, 19 Jan 2025 09:27:54 +0200 Message-ID: X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Leon Romanovsky The Vital Product Data (VPD) attribute is not readable by regular user without root permissions. Such restriction is not needed at all for Mellanox devices, as data presented in that VPD is not sensitive and access to the HW is safe and well tested. This change changes the permissions of the VPD attribute to be accessible for read by all users for Mellanox devices, while write continue to be restricted to root only. The main use case is to remove need to have root/setuid permissions while using monitoring library [1]. [leonro@vm ~]$ lspci |grep nox 00:09.0 Ethernet controller: Mellanox Technologies MT2910 Family [ConnectX-7] Before: [leonro@vm ~]$ ls -al /sys/bus/pci/devices/0000:00:09.0/vpd -rw------- 1 root root 0 Nov 13 12:30 /sys/bus/pci/devices/0000:00:09.0/vpd After: [leonro@vm ~]$ ls -al /sys/bus/pci/devices/0000:00:09.0/vpd -rw-r--r-- 1 root root 0 Nov 13 12:30 /sys/bus/pci/devices/0000:00:09.0/vpd [1] https://developer.nvidia.com/management-library-nvml Signed-off-by: Leon Romanovsky --- Changelog: v4: * Change comment to the variant suggested by Stephen v3: https://lore.kernel.org/all/18f36b3cbe2b7e67eed876337f8ba85afbc12e73.1733227737.git.leon@kernel.org * Used | to change file attributes * Remove WARN_ON v2: https://lore.kernel.org/all/61a0fa74461c15edfae76222522fa445c28bec34.1731502431.git.leon@kernel.org * Another implementation to make sure that user is presented with correct permissions without need for driver intervention. v1: https://lore.kernel.org/all/cover.1731005223.git.leonro@nvidia.com * Changed implementation from open-read-to-everyone to be opt-in * Removed stable and Fixes tags, as it seems like feature now. v0: https://lore.kernel.org/all/65791906154e3e5ea12ea49127cf7c707325ca56.1730102428.git.leonro@nvidia.com/ --- drivers/pci/vpd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c index a469bcbc0da7..c873ab47526b 100644 --- a/drivers/pci/vpd.c +++ b/drivers/pci/vpd.c @@ -332,6 +332,13 @@ static umode_t vpd_attr_is_visible(struct kobject *kobj, if (!pdev->vpd.cap) return 0; + /* + * On Mellanox devices reading VPD is safe for unprivileged users, + * so just add needed bits to allow read. + */ + if (unlikely(pdev->vendor == PCI_VENDOR_ID_MELLANOX)) + return a->attr.mode | 0044; + return a->attr.mode; }