diff mbox series

[v2,2/5] tools: ynl: provide symlinks to user-facing scripts for compatibility

Message ID ce653225895177ab5b861d5348b1c610919f4779.1733755068.git.jstancek@redhat.com (mailing list archive)
State Superseded
Headers show
Series tools: ynl: add install target | expand

Checks

Context Check Description
netdev/series_format warning Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success Errors and warnings before: 0 (+23) this patch: 0 (+23)
netdev/cc_maintainers warning 2 maintainers not CCed: rrameshbabu@nvidia.com dtatulea@nvidia.com
netdev/build_clang success Errors and warnings before: 1 this patch: 1
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 5 this patch: 5
netdev/checkpatch warning WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-12-10--06-00 (tests: 764)

Commit Message

Jan Stancek Dec. 9, 2024, 2:47 p.m. UTC 
For backwards compatibility provide also symlinks from original location
of user facing scripts.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 tools/net/ynl/cli.py         | 1 +
 tools/net/ynl/ethtool.py     | 1 +
 tools/net/ynl/ynl-gen-c.py   | 1 +
 tools/net/ynl/ynl-gen-rst.py | 1 +
 4 files changed, 4 insertions(+)
 create mode 120000 tools/net/ynl/cli.py
 create mode 120000 tools/net/ynl/ethtool.py
 create mode 120000 tools/net/ynl/ynl-gen-c.py
 create mode 120000 tools/net/ynl/ynl-gen-rst.py

Comments

Jakub Kicinski Dec. 11, 2024, 3:26 a.m. UTC | #1 
On Mon,  9 Dec 2024 15:47:14 +0100 Jan Stancek wrote:
> For backwards compatibility provide also symlinks from original location
> of user facing scripts.

Did someone ask for this? Does everything work without the symlinks?
If the answers are "no", "yes" then let's try without this patch.
In tree users should be able to adjust.
Donald Hunter Dec. 11, 2024, 9:21 a.m. UTC | #2 
On Wed, 11 Dec 2024 at 03:26, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon,  9 Dec 2024 15:47:14 +0100 Jan Stancek wrote:
> > For backwards compatibility provide also symlinks from original location
> > of user facing scripts.
>
> Did someone ask for this? Does everything work without the symlinks?
> If the answers are "no", "yes" then let's try without this patch.
> In tree users should be able to adjust.

I asked for the symlinks for cli.py and ethtool.py to avoid surprising
people when they move. The ynl-gen- scripts are primarily used in-tree
via Makefiles so I didn't think they should be symlinked. Happy to go
with your suggestion to drop this if you'd prefer not to have any
symlinks.

Thanks,
Donald
Jan Stancek Dec. 11, 2024, 12:42 p.m. UTC | #3 
On Wed, Dec 11, 2024 at 10:21 AM Donald Hunter <donald.hunter@gmail.com> wrote:
>
> On Wed, 11 Dec 2024 at 03:26, Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Mon,  9 Dec 2024 15:47:14 +0100 Jan Stancek wrote:
> > > For backwards compatibility provide also symlinks from original location
> > > of user facing scripts.
> >
> > Did someone ask for this? Does everything work without the symlinks?
> > If the answers are "no", "yes" then let's try without this patch.
> > In tree users should be able to adjust.
>
> I asked for the symlinks for cli.py and ethtool.py to avoid surprising
> people when they move. The ynl-gen- scripts are primarily used in-tree
> via Makefiles so I didn't think they should be symlinked. Happy to go
> with your suggestion to drop this if you'd prefer not to have any
> symlinks.

I'll drop them, we can always add them later in case someone
_really_ needs original script locations.

>
> Thanks,
> Donald
>
Jakub Kicinski Dec. 12, 2024, 2:13 a.m. UTC | #4 
On Wed, 11 Dec 2024 13:42:28 +0100 Jan Stancek wrote:
> > > Did someone ask for this? Does everything work without the symlinks?
> > > If the answers are "no", "yes" then let's try without this patch.
> > > In tree users should be able to adjust.  
> >
> > I asked for the symlinks for cli.py and ethtool.py to avoid surprising
> > people when they move. The ynl-gen- scripts are primarily used in-tree
> > via Makefiles so I didn't think they should be symlinked. Happy to go
> > with your suggestion to drop this if you'd prefer not to have any
> > symlinks.  
> 
> I'll drop them, we can always add them later in case someone
> _really_ needs original script locations.

FWIW that's my thinking, too.
diff mbox series

Patch

diff --git a/tools/net/ynl/cli.py b/tools/net/ynl/cli.py
new file mode 120000
index 000000000000..c26fb97ae611
--- /dev/null
+++ b/tools/net/ynl/cli.py
@@ -0,0 +1 @@ 
+pyynl/cli.py
\ No newline at end of file
diff --git a/tools/net/ynl/ethtool.py b/tools/net/ynl/ethtool.py
new file mode 120000
index 000000000000..deea4569a939
--- /dev/null
+++ b/tools/net/ynl/ethtool.py
@@ -0,0 +1 @@ 
+pyynl/ethtool.py
\ No newline at end of file
diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
new file mode 120000
index 000000000000..716d34fa1257
--- /dev/null
+++ b/tools/net/ynl/ynl-gen-c.py
@@ -0,0 +1 @@ 
+pyynl/ynl_gen_c.py
\ No newline at end of file
diff --git a/tools/net/ynl/ynl-gen-rst.py b/tools/net/ynl/ynl-gen-rst.py
new file mode 120000
index 000000000000..b02558f540ec
--- /dev/null
+++ b/tools/net/ynl/ynl-gen-rst.py
@@ -0,0 +1 @@ 
+pyynl/ynl_gen_rst.py
\ No newline at end of file