| Message ID | d096084167d56706d620afe5136cf37a2d34d1b9.1733412063.git.petrm@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 752b1c8d8b409f2b03e61e153696689ee081bf07 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | vxlan: Support user-defined reserved bits | expand |
On 12/5/24 17:40, Petr Machata wrote: > The VXLAN driver so far has not increased the error counters for packets > that set reserved bits. It does so for other packet errors, so do it for > this case as well. > > Signed-off-by: Petr Machata <petrm@nvidia.com> > Reviewed-by: Ido Schimmel <idosch@nvidia.com> > --- > > Notes: > CC: Menglong Dong <menglong8.dong@gmail.com> > CC: Guillaume Nault <gnault@redhat.com> > CC: Alexander Lobakin <aleksander.lobakin@intel.com> > CC: Breno Leitao <leitao@debian.org> > > drivers/net/vxlan/vxlan_core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c > index f6118de81b8a..b8afdcbdf235 100644 > --- a/drivers/net/vxlan/vxlan_core.c > +++ b/drivers/net/vxlan/vxlan_core.c > @@ -1721,6 +1721,10 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) > * little more security in adding extensions to VXLAN. > */ > reason = SKB_DROP_REASON_VXLAN_INVALID_HDR; > + DEV_STATS_INC(vxlan->dev, rx_frame_errors); > + DEV_STATS_INC(vxlan->dev, rx_errors); > + vxlan_vnifilter_count(vxlan, vni, vninode, > + VXLAN_VNI_STATS_RX_ERRORS, 0); > goto drop; > } > Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index f6118de81b8a..b8afdcbdf235 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -1721,6 +1721,10 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) * little more security in adding extensions to VXLAN. */ reason = SKB_DROP_REASON_VXLAN_INVALID_HDR; + DEV_STATS_INC(vxlan->dev, rx_frame_errors); + DEV_STATS_INC(vxlan->dev, rx_errors); + vxlan_vnifilter_count(vxlan, vni, vninode, + VXLAN_VNI_STATS_RX_ERRORS, 0); goto drop; }