| Message ID | d20b291dc4dd5030adefbabef7dda1bf2206a15f.1722421644.git.0x1207@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: FPE via ethtool + tc | expand |
On Wed, Jul 31, 2024 at 06:43:12PM +0800, Furong Xu wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > index b23b920eedb1..5228493bc68c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h > @@ -345,6 +345,9 @@ struct stmmac_priv { > struct work_struct fpe_task; > char wq_name[IFNAMSIZ + 4]; > > + /* Serialize access to MAC Merge state between ethtool requests */ > + struct mutex mm_lock; The thing is, ethtool requests are already serialized by the rtnl_mutex. The purpose of a driver-level locking scheme is to serialize the ethtool requests with things like interrupts, work queues, etc, to avoid corrupting driver state. Surprisingly, even if the code runs indeed very much unlocked, I don't see too many races with severe consequences. There are some exceptions though. Like for example, stmmac_fpe_handshake(enable=false) races on priv->plat->fpe_cfg->lo_fpe_state and priv->plat->fpe_cfg->lp_fpe_state with stmmac_fpe_lp_task(). static void stmmac_fpe_lp_task(struct work_struct *work) { enum stmmac_fpe_state *lo_state = &fpe_cfg->lo_fpe_state; enum stmmac_fpe_state *lp_state = &fpe_cfg->lp_fpe_state; /* Bail out immediately if FPE handshake is OFF */ if (*lo_state == FPE_STATE_OFF || !*hs_enable) break; if (*lo_state == FPE_STATE_ENTERING_ON && *lp_state == FPE_STATE_ENTERING_ON) { netdev_dbg(priv->dev, "configured FPE\n"); Another CPU runs here: stmmac_set_mm() -> stmmac_fpe_handshake(enable=false) -> priv->plat->fpe_cfg->lo_fpe_state = FPE_STATE_OFF; -> priv->plat->fpe_cfg->lp_fpe_state = FPE_STATE_OFF; *lo_state = FPE_STATE_ON; *lp_state = FPE_STATE_ON; netdev_dbg(priv->dev, "!!! BOTH FPE stations ON\n"); break; } ... } Simply put, due to lack of locking, stmmac_set_mm() can try to stop the FPE verification task but fail, since it can lose the race. I would expect a way for stmmac_fpe_handshake() to be able to stop further FPE interrupts from taking place (or at least from being processed), and then flush_workqueue(&priv->fpe_task) to make sure that all pending stmmac_fpe_lp_task()s have finished. > + > /* TC Handling */ > unsigned int tc_entries_max; > unsigned int tc_off_max; > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > index 7008219fd88d..ca85e8694285 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > @@ -19,6 +19,7 @@ > #include "stmmac.h" > #include "dwmac_dma.h" > #include "dwxgmac2.h" > +#include "dwmac5.h" > > #define REG_SPACE_SIZE 0x1060 > #define GMAC4_REG_SPACE_SIZE 0x116C > @@ -1270,6 +1271,113 @@ static int stmmac_set_tunable(struct net_device *dev, > return ret; > } > > +static int stmmac_get_mm(struct net_device *ndev, > + struct ethtool_mm_state *state) > +{ > + struct stmmac_priv *priv = netdev_priv(ndev); > + enum stmmac_fpe_state lo_state = priv->plat->fpe_cfg->lo_fpe_state; I expect this to have to serialize with the writers of lo_fpe_state on some sort of lock. May have to be a spinlock (making the priv->mm_lock mutex inadequate in its current form), since stmmac_interrupt() is not threaded and thus runs in atomic context. > + u32 add_frag_size; > + > + if (!priv->dma_cap.fpesel) > + return -EOPNOTSUPP; > + > + mutex_lock(&priv->mm_lock); > + > + /* If FPE is supported by hardware, preemptible MAC is always enabled */ > + state->pmac_enabled = true; Documentation/networking/ethtool-netlink.rst: "set if RX of preemptible and SMD-V frames is enabled". You can use the pmac_enabled knob as a hook to call stmmac_fpe_start_wq() and stmmac_fpe_stop_wq(), as well as whether to process FPE interrupt status bits. The idea being that as long as the pMAC is enabled, you are obliged to respond to mPackets from the link partner (to allow his side* of the verification process to run). Otherwise you are not - you should behave like a FPE-incapable NIC. In fact, this is what the manual_failed_verification() portion of the kselftest attempts to test. *This is actually a misconception of the current driver implementation. The two verification processes are completely independent, since each refers to its TX side only. One device can have ethtool --set-mm verify-enabled on, and the other off. There is no reason at all to keep a local device state + a link partner state, and to make any decision in the driver based on the LP state. Like here: stmmac_fpe_lp_task(): if (*lo_state == FPE_STATE_ENTERING_ON && *lp_state == FPE_STATE_ENTERING_ON) { // lp_state does not matter netdev_dbg(priv->dev, "configured FPE\n"); *lo_state = FPE_STATE_ON; *lp_state = FPE_STATE_ON; netdev_dbg(priv->dev, "!!! BOTH FPE stations ON\n"); break; } if ((*lo_state == FPE_STATE_CAPABLE || *lo_state == FPE_STATE_ENTERING_ON) && *lp_state != FPE_STATE_ON) { // lp_state does not matter netdev_dbg(priv->dev, SEND_VERIFY_MPAKCET_FMT, *lo_state, *lp_state); stmmac_fpe_send_mpacket(priv, priv->ioaddr, fpe_cfg, MPACKET_VERIFY); } To my superficial reading of the driver, the distinction between FPE_STATE_ENTERING_ON and FPE_STATE_ON exists solely to wait for the LP to finish its verification as well. I think you noticed that is a non-goal as well, because your stmmac_get_mm() implementation reports ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED when we are in either of the 2 states: FPE_STATE_ENTERING_ON or FPE_STATE_ON. I hope you don't mind me if I say that since waiting both sides to finish verification is a non-goal, I disagree with your choice of papering over the existence of the 2 FPE driver states. I would recommend consolidating them into a single one. Another mistake relating to this (TX verification processes are not necessarily symmetric) is: stmmac_set_mm() -> stmmac_fpe_handshake(priv, cfg->verify_enabled) -> priv->plat->fpe_cfg->hs_enable = enable stmmac_fpe_event_status(): if (status == FPE_EVENT_UNKNOWN || !*hs_enable) return; if ((status & FPE_EVENT_RVER) == FPE_EVENT_RVER) { /* If LP has sent Verify mPacket, send back a Responds mPacket */ if (*hs_enable) stmmac_fpe_send_mpacket(priv, priv->ioaddr, fpe_cfg, MPACKET_RESPONSE); } We should always respond to the link partner's Verify mPacket as long as pmac_enabled=true, and not just if hs_enable=true. > + > + state->verify_time = priv->plat->fpe_cfg->verify_time; > + > + /* 802.3-2018 clause 30.14.1.6, says that the aMACMergeVerifyTime > + * variable has a range between 1 and 128 ms inclusive. Limit to that. > + */ > + state->max_verify_time = 128; > + > + if (lo_state == FPE_STATE_CAPABLE) > + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_VERIFYING; > + else if (lo_state == FPE_STATE_ENTERING_ON || lo_state == FPE_STATE_ON) > + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED; > + else if (lo_state == FPE_STATE_OFF) > + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_DISABLED; > + else > + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_UNKNOWN; > + > + /* Cannot read MAC_FPE_CTRL_STS register here, or FPE interrupt events > + * can lose. s/lose/be lost/ > + * > + * See commit 37e4b8df27bc ("net: stmmac: fix FPE events losing") > + */ > + state->tx_enabled = !!(priv->plat->fpe_cfg->fpe_csr == EFPE); > + > + /* FPE active if common tx_enabled and verification success or disabled (forced) */ > + state->tx_active = state->tx_enabled && > + (state->verify_status == ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED || > + state->verify_status == ETHTOOL_MM_VERIFY_STATUS_DISABLED); > + > + state->verify_enabled = priv->plat->fpe_cfg->hs_enable; > + > + add_frag_size = stmmac_fpe_get_add_frag_size(priv, priv->ioaddr); > + state->tx_min_frag_size = ethtool_mm_frag_size_add_to_min(add_frag_size); > + > + state->rx_min_frag_size = ETH_ZLEN; > + > + mutex_unlock(&priv->mm_lock); > + > + return 0; > +} > + > +static int stmmac_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg, > + struct netlink_ext_ack *extack) > +{ > + struct stmmac_priv *priv = netdev_priv(ndev); > + u32 add_frag_size; > + int err; > + > + if (!priv->dma_cap.fpesel) > + return -EOPNOTSUPP; > + > + err = ethtool_mm_frag_size_min_to_add(cfg->tx_min_frag_size, > + &add_frag_size, extack); > + if (err) > + return err; > + > + mutex_lock(&priv->mm_lock); > + > + priv->plat->fpe_cfg->verify_time = cfg->verify_time; > + > + stmmac_fpe_configure(priv, priv->ioaddr, priv->plat->fpe_cfg, > + priv->plat->tx_queues_to_use, > + priv->plat->rx_queues_to_use, > + cfg->tx_enabled); > + > + stmmac_fpe_set_add_frag_size(priv, priv->ioaddr, add_frag_size); > + > + stmmac_fpe_handshake(priv, cfg->verify_enabled); > + > + mutex_unlock(&priv->mm_lock); > + > + return 0; > +} > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 12689774d755..9b1cf81c50ea 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -7384,7 +7384,6 @@ static void stmmac_fpe_lp_task(struct work_struct *work) > enum stmmac_fpe_state *lo_state = &fpe_cfg->lo_fpe_state; > enum stmmac_fpe_state *lp_state = &fpe_cfg->lp_fpe_state; > bool *hs_enable = &fpe_cfg->hs_enable; > - bool *enable = &fpe_cfg->enable; > int retries = 20; > > while (retries-- > 0) { > @@ -7394,11 +7393,6 @@ static void stmmac_fpe_lp_task(struct work_struct *work) > > if (*lo_state == FPE_STATE_ENTERING_ON && > *lp_state == FPE_STATE_ENTERING_ON) { > - stmmac_fpe_configure(priv, priv->ioaddr, > - fpe_cfg, > - priv->plat->tx_queues_to_use, > - priv->plat->rx_queues_to_use, > - *enable); > > netdev_info(priv->dev, "configured FPE\n"); > > @@ -7418,7 +7412,7 @@ static void stmmac_fpe_lp_task(struct work_struct *work) > MPACKET_VERIFY); > } > /* Sleep then retry */ > - msleep(500); > + msleep(fpe_cfg->verify_time); FWIW, if you want to follow the standard, I guess you should modify "retries" to 3 as well - this is the constant that 802.3 uses for verifyLimit. It helps make the verification process fail more predictably (within verifyTime * 3 ms). > } > > clear_bit(__FPE_TASK_SCHED, &priv->fpe_task_state); > @@ -7720,6 +7714,7 @@ int stmmac_dvr_probe(struct device *device, > stmmac_napi_add(ndev); > > mutex_init(&priv->lock); > + mutex_init(&priv->mm_lock); > > /* If a specific clk_csr value is passed from the platform > * this means that the CSR Clock Range selection cannot be
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index f98741d2607e..af871cce767e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -1268,6 +1268,8 @@ const struct stmmac_ops dwmac410_ops = { .fpe_configure = dwmac5_fpe_configure, .fpe_send_mpacket = dwmac5_fpe_send_mpacket, .fpe_irq_status = dwmac5_fpe_irq_status, + .fpe_get_add_frag_size = dwmac5_fpe_get_add_frag_size, + .fpe_set_add_frag_size = dwmac5_fpe_set_add_frag_size, .add_hw_vlan_rx_fltr = dwmac4_add_hw_vlan_rx_fltr, .del_hw_vlan_rx_fltr = dwmac4_del_hw_vlan_rx_fltr, .restore_hw_vlan_rx_fltr = dwmac4_restore_hw_vlan_rx_fltr, @@ -1320,6 +1322,8 @@ const struct stmmac_ops dwmac510_ops = { .fpe_configure = dwmac5_fpe_configure, .fpe_send_mpacket = dwmac5_fpe_send_mpacket, .fpe_irq_status = dwmac5_fpe_irq_status, + .fpe_get_add_frag_size = dwmac5_fpe_get_add_frag_size, + .fpe_set_add_frag_size = dwmac5_fpe_set_add_frag_size, .add_hw_vlan_rx_fltr = dwmac4_add_hw_vlan_rx_fltr, .del_hw_vlan_rx_fltr = dwmac4_del_hw_vlan_rx_fltr, .restore_hw_vlan_rx_fltr = dwmac4_restore_hw_vlan_rx_fltr, diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac5.c b/drivers/net/ethernet/stmicro/stmmac/dwmac5.c index e02cebc3f1b7..5d132bada3fe 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac5.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac5.c @@ -638,3 +638,20 @@ void dwmac5_fpe_send_mpacket(void __iomem *ioaddr, struct stmmac_fpe_cfg *cfg, writel(value, ioaddr + MAC_FPE_CTRL_STS); } + +int dwmac5_fpe_get_add_frag_size(void __iomem *ioaddr) +{ + return FIELD_GET(AFSZ, readl(ioaddr + MTL_FPE_CTRL_STS)); +} + +void dwmac5_fpe_set_add_frag_size(void __iomem *ioaddr, u32 add_frag_size) +{ + u32 value; + + value = readl(ioaddr + MTL_FPE_CTRL_STS); + + value &= ~AFSZ; + value |= FIELD_PREP(AFSZ, add_frag_size); + + writel(value, ioaddr + MTL_FPE_CTRL_STS); +} diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac5.h b/drivers/net/ethernet/stmicro/stmmac/dwmac5.h index bf33a51d229e..6b1c9d2da308 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac5.h +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac5.h @@ -39,6 +39,9 @@ #define MAC_PPSx_INTERVAL(x) (0x00000b88 + ((x) * 0x10)) #define MAC_PPSx_WIDTH(x) (0x00000b8c + ((x) * 0x10)) +#define MTL_FPE_CTRL_STS 0x00000c90 +#define AFSZ GENMASK(1, 0) + #define MTL_RXP_CONTROL_STATUS 0x00000ca0 #define RXPI BIT(31) #define NPE GENMASK(23, 16) @@ -109,5 +112,7 @@ void dwmac5_fpe_send_mpacket(void __iomem *ioaddr, struct stmmac_fpe_cfg *cfg, enum stmmac_mpacket_type type); int dwmac5_fpe_irq_status(void __iomem *ioaddr, struct net_device *dev); +int dwmac5_fpe_get_add_frag_size(void __iomem *ioaddr); +void dwmac5_fpe_set_add_frag_size(void __iomem *ioaddr, u32 add_frag_size); #endif /* __DWMAC5_H__ */ diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h index e53c32362774..f868ffc3e64f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.h +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h @@ -425,6 +425,8 @@ struct stmmac_ops { struct stmmac_fpe_cfg *cfg, enum stmmac_mpacket_type type); int (*fpe_irq_status)(void __iomem *ioaddr, struct net_device *dev); + int (*fpe_get_add_frag_size)(void __iomem *ioaddr); + void (*fpe_set_add_frag_size)(void __iomem *ioaddr, u32 add_frag_size); }; #define stmmac_core_init(__priv, __args...) \ @@ -529,6 +531,10 @@ struct stmmac_ops { stmmac_do_void_callback(__priv, mac, fpe_send_mpacket, __args) #define stmmac_fpe_irq_status(__priv, __args...) \ stmmac_do_callback(__priv, mac, fpe_irq_status, __args) +#define stmmac_fpe_get_add_frag_size(__priv, __args...) \ + stmmac_do_callback(__priv, mac, fpe_get_add_frag_size, __args) +#define stmmac_fpe_set_add_frag_size(__priv, __args...) \ + stmmac_do_void_callback(__priv, mac, fpe_set_add_frag_size, __args) /* PTP and HW Timer helpers */ struct stmmac_hwtimestamp { diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index b23b920eedb1..5228493bc68c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h @@ -345,6 +345,9 @@ struct stmmac_priv { struct work_struct fpe_task; char wq_name[IFNAMSIZ + 4]; + /* Serialize access to MAC Merge state between ethtool requests */ + struct mutex mm_lock; + /* TC Handling */ unsigned int tc_entries_max; unsigned int tc_off_max; diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 7008219fd88d..ca85e8694285 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -19,6 +19,7 @@ #include "stmmac.h" #include "dwmac_dma.h" #include "dwxgmac2.h" +#include "dwmac5.h" #define REG_SPACE_SIZE 0x1060 #define GMAC4_REG_SPACE_SIZE 0x116C @@ -1270,6 +1271,113 @@ static int stmmac_set_tunable(struct net_device *dev, return ret; } +static int stmmac_get_mm(struct net_device *ndev, + struct ethtool_mm_state *state) +{ + struct stmmac_priv *priv = netdev_priv(ndev); + enum stmmac_fpe_state lo_state = priv->plat->fpe_cfg->lo_fpe_state; + u32 add_frag_size; + + if (!priv->dma_cap.fpesel) + return -EOPNOTSUPP; + + mutex_lock(&priv->mm_lock); + + /* If FPE is supported by hardware, preemptible MAC is always enabled */ + state->pmac_enabled = true; + + state->verify_time = priv->plat->fpe_cfg->verify_time; + + /* 802.3-2018 clause 30.14.1.6, says that the aMACMergeVerifyTime + * variable has a range between 1 and 128 ms inclusive. Limit to that. + */ + state->max_verify_time = 128; + + if (lo_state == FPE_STATE_CAPABLE) + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_VERIFYING; + else if (lo_state == FPE_STATE_ENTERING_ON || lo_state == FPE_STATE_ON) + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED; + else if (lo_state == FPE_STATE_OFF) + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_DISABLED; + else + state->verify_status = ETHTOOL_MM_VERIFY_STATUS_UNKNOWN; + + /* Cannot read MAC_FPE_CTRL_STS register here, or FPE interrupt events + * can lose. + * + * See commit 37e4b8df27bc ("net: stmmac: fix FPE events losing") + */ + state->tx_enabled = !!(priv->plat->fpe_cfg->fpe_csr == EFPE); + + /* FPE active if common tx_enabled and verification success or disabled (forced) */ + state->tx_active = state->tx_enabled && + (state->verify_status == ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED || + state->verify_status == ETHTOOL_MM_VERIFY_STATUS_DISABLED); + + state->verify_enabled = priv->plat->fpe_cfg->hs_enable; + + add_frag_size = stmmac_fpe_get_add_frag_size(priv, priv->ioaddr); + state->tx_min_frag_size = ethtool_mm_frag_size_add_to_min(add_frag_size); + + state->rx_min_frag_size = ETH_ZLEN; + + mutex_unlock(&priv->mm_lock); + + return 0; +} + +static int stmmac_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg, + struct netlink_ext_ack *extack) +{ + struct stmmac_priv *priv = netdev_priv(ndev); + u32 add_frag_size; + int err; + + if (!priv->dma_cap.fpesel) + return -EOPNOTSUPP; + + err = ethtool_mm_frag_size_min_to_add(cfg->tx_min_frag_size, + &add_frag_size, extack); + if (err) + return err; + + mutex_lock(&priv->mm_lock); + + priv->plat->fpe_cfg->verify_time = cfg->verify_time; + + stmmac_fpe_configure(priv, priv->ioaddr, priv->plat->fpe_cfg, + priv->plat->tx_queues_to_use, + priv->plat->rx_queues_to_use, + cfg->tx_enabled); + + stmmac_fpe_set_add_frag_size(priv, priv->ioaddr, add_frag_size); + + stmmac_fpe_handshake(priv, cfg->verify_enabled); + + mutex_unlock(&priv->mm_lock); + + return 0; +} + +static void stmmac_get_mm_stats(struct net_device *ndev, + struct ethtool_mm_stats *s) +{ + struct stmmac_priv *priv = netdev_priv(ndev); + struct stmmac_counters *mmc = &priv->mmc; + + if (!priv->dma_cap.rmon) + return; + + stmmac_mmc_read(priv, priv->mmcaddr, mmc); + + s->MACMergeFrameAssErrorCount = mmc->mmc_rx_packet_assembly_err_cntr; + s->MACMergeFrameSmdErrorCount = mmc->mmc_rx_packet_smd_err_cntr; + s->MACMergeFrameAssOkCount = mmc->mmc_rx_packet_assembly_ok_cntr; + s->MACMergeFragCountRx = mmc->mmc_rx_fpe_fragment_cntr; + s->MACMergeFragCountTx = mmc->mmc_tx_fpe_fragment_cntr; + s->MACMergeHoldCount = mmc->mmc_tx_hold_req_cntr; +} + static const struct ethtool_ops stmmac_ethtool_ops = { .supported_coalesce_params = ETHTOOL_COALESCE_USECS | ETHTOOL_COALESCE_MAX_FRAMES, @@ -1309,6 +1417,9 @@ static const struct ethtool_ops stmmac_ethtool_ops = { .set_tunable = stmmac_set_tunable, .get_link_ksettings = stmmac_ethtool_get_link_ksettings, .set_link_ksettings = stmmac_ethtool_set_link_ksettings, + .get_mm = stmmac_get_mm, + .set_mm = stmmac_set_mm, + .get_mm_stats = stmmac_get_mm_stats, }; void stmmac_set_ethtool_ops(struct net_device *netdev) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 12689774d755..9b1cf81c50ea 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -7384,7 +7384,6 @@ static void stmmac_fpe_lp_task(struct work_struct *work) enum stmmac_fpe_state *lo_state = &fpe_cfg->lo_fpe_state; enum stmmac_fpe_state *lp_state = &fpe_cfg->lp_fpe_state; bool *hs_enable = &fpe_cfg->hs_enable; - bool *enable = &fpe_cfg->enable; int retries = 20; while (retries-- > 0) { @@ -7394,11 +7393,6 @@ static void stmmac_fpe_lp_task(struct work_struct *work) if (*lo_state == FPE_STATE_ENTERING_ON && *lp_state == FPE_STATE_ENTERING_ON) { - stmmac_fpe_configure(priv, priv->ioaddr, - fpe_cfg, - priv->plat->tx_queues_to_use, - priv->plat->rx_queues_to_use, - *enable); netdev_info(priv->dev, "configured FPE\n"); @@ -7418,7 +7412,7 @@ static void stmmac_fpe_lp_task(struct work_struct *work) MPACKET_VERIFY); } /* Sleep then retry */ - msleep(500); + msleep(fpe_cfg->verify_time); } clear_bit(__FPE_TASK_SCHED, &priv->fpe_task_state); @@ -7720,6 +7714,7 @@ int stmmac_dvr_probe(struct device *device, stmmac_napi_add(ndev); mutex_init(&priv->lock); + mutex_init(&priv->mm_lock); /* If a specific clk_csr value is passed from the platform * this means that the CSR Clock Range selection cannot be diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index 84e13bd5df28..707a6916e51a 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -162,6 +162,7 @@ struct stmmac_fpe_cfg { enum stmmac_fpe_state lp_fpe_state; /* Link Partner FPE state */ enum stmmac_fpe_state lo_fpe_state; /* Local station FPE state */ u32 fpe_csr; /* MAC_FPE_CTRL_STS reg cache */ + u32 verify_time; /* see struct ethtool_mm_state */ }; struct stmmac_safety_feature_cfg {
Implement ethtool --show-mm and --set-mm callbacks. 0) Setup two DWMAC CORE 5.10a devices, connect in a back-to-back manner. 1) After kernel booted, get initial status: ethtool --include-statistics --json --show-mm eth1 [ { "ifname": "eth1", "pmac-enabled": true, "tx-enabled": false, "tx-active": false, "tx-min-frag-size": 60, "rx-min-frag-size": 60, "verify-enabled": false, "verify-time": 0, "max-verify-time": 128, "verify-status": "DISABLED", "statistics": { "MACMergeFrameAssErrorCount": 0, "MACMergeFrameSmdErrorCount": 0, "MACMergeFrameAssOkCount": 0, "MACMergeFragCountRx": 0, "MACMergeFragCountTx": 0, "MACMergeHoldCount": 0 } } ] 3) Enable FPE on local device, keep FPE disabled on remote device: ethtool --set-mm eth1 verify-enabled on verify-time 100 tx-enabled on 4) Get status on local device: ethtool --include-statistics --json --show-mm eth1 [ { "ifname": "eth1", "pmac-enabled": true, "tx-enabled": true, "tx-active": false, "tx-min-frag-size": 60, "rx-min-frag-size": 60, "verify-enabled": true, "verify-time": 100, "max-verify-time": 128, "verify-status": "VERIFYING", "statistics": { "MACMergeFrameAssErrorCount": 0, "MACMergeFrameSmdErrorCount": 0, "MACMergeFrameAssOkCount": 0, "MACMergeFragCountRx": 0, "MACMergeFragCountTx": 0, "MACMergeHoldCount": 0 } } ] 5) Enable FPE on remote device, handshake can be finished now: ethtool --set-mm eth1 verify-enabled on verify-time 100 tx-enabled on 6) Get status on local and remote device, both report SUCCEEDED: ethtool --include-statistics --json --show-mm eth1 [ { "ifname": "eth1", "pmac-enabled": true, "tx-enabled": true, "tx-active": true, "tx-min-frag-size": 60, "rx-min-frag-size": 60, "verify-enabled": true, "verify-time": 100, "max-verify-time": 128, "verify-status": "SUCCEEDED", "statistics": { "MACMergeFrameAssErrorCount": 0, "MACMergeFrameSmdErrorCount": 0, "MACMergeFrameAssOkCount": 0, "MACMergeFragCountRx": 0, "MACMergeFragCountTx": 0, "MACMergeHoldCount": 0 } } ] 7) tc-mqprio or tc-taprio can be used to select whether traffic classes are express or preemptible. Signed-off-by: Furong Xu <0x1207@gmail.com> --- .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 4 + drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 17 +++ drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 5 + drivers/net/ethernet/stmicro/stmmac/hwif.h | 6 + drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 + .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 111 ++++++++++++++++++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 9 +- include/linux/stmmac.h | 1 + 8 files changed, 149 insertions(+), 7 deletions(-)